public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] mach-integrator: modernize clock event registration
Date: Thu, 8 Sep 2011 09:55:02 +0100	[thread overview]
Message-ID: <20110908085502.GB14953@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.LFD.2.02.1109071202000.2723@ionos>

On Wed, Sep 07, 2011 at 12:02:52PM +0200, Thomas Gleixner wrote:
> On Wed, 7 Sep 2011, Linus Walleij wrote:
> 
> > From: Linus Walleij <linus.walleij@linaro.org>
> > 
> > Drop the reload value for the timer - the timekeeping code
> > will call the .set_next_event to set this anyway.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

> > 
> > Drop mult, shift and delta calculations and let the
> > clockevent core scale this as appropriate.
> > 
> > Set the minimum interval to 1 rather than 15 (0xf), there
> > is nothing in the data sheets I have indicating that 15
> > should be some minimum value.
> > 
> > Cc: Russell King <linux@arm.linux.org.uk>
> 
> Acked-by: Thomas Gleixner <tglx@linutronix.de>

I mentioned to Thomas that which I've underlined above yesterday after I
received Thomas' ack.  I was expecting Thomas to reply about this, but
that obviously hasn't happened, so now that it's appeared in the patch
system, it's become my problem to deal with.

My understanding is that periodic timers are not setup by the generic
clock event code, and so we do need to keep the 'timer_reload' stuff
around.  Note that patch 2 deletes the register write for this too,
so you actually have one logical change split across patch 2 and 3.

  reply	other threads:[~2011-09-08  8:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-07  8:31 [PATCH 3/4] mach-integrator: modernize clock event registration Linus Walleij
2011-09-07 10:02 ` Thomas Gleixner
2011-09-08  8:55   ` Russell King - ARM Linux [this message]
2011-09-08  9:23     ` Linus Walleij
2011-09-08  9:34       ` Thomas Gleixner
2011-09-08  9:33     ` Thomas Gleixner
2011-09-08 20:18     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110908085502.GB14953@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox