linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ASoC: omap: convert per-board modules to platform drivers
Date: Fri, 9 Sep 2011 20:01:35 +0100	[thread overview]
Message-ID: <20110909190134.GA14520@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20110909161151.GA3515@opensource.wolfsonmicro.com>

On Fri, Sep 09, 2011 at 09:11:52AM -0700, Mark Brown wrote:
> On Fri, Sep 09, 2011 at 10:41:56AM +0100, Russell King - ARM Linux wrote:
> > On Thu, Sep 08, 2011 at 04:59:04PM -0700, Mark Brown wrote:
> 
> > > The problem is that someone has to manually go and add the device to
> > > every board that needs one and people find that tedious and slightly
> > > inelegant
> 
> > Sheesh.  So now you're arguing against your statement above?  Please
> > stop wasting my time.
> 
> There's two things going on here - what we are doing and what people
> would like to be able to do.  What we are doing is explicitly adding
> devices, what people would like to do is infer the devices from the
> board type.  Personally I'm totally happy with explicitly adding an
> audio device, but not everyone is and I do understand where they're
> coming from.

Well, with DT, there won't be any 'board type' anymore.  There won't be
any 'machine_is_xxx()' to sort it out anymore.  Using DT, all that will
be history - it's all got to be sorted out by either devices or device
properties.

So, given that, I don't see the logic of having two methods - it might
as well be dealt with by devices and [platform data for non-DT | DT
properties], and which then means we have everything working the same
way irrespective of what the backing data for the platform actually is.

Therefore, as we are heading for DT, I'd definitely say that having
machine_is_xxx() outside of arch/arm is a bug, no less and no more.

  reply	other threads:[~2011-09-09 19:01 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-08 17:34 [PATCH v2] ASoC: omap: convert per-board modules to platform drivers Mans Rullgard
2011-09-08 18:17 ` Jassi Brar
2011-09-08 18:18   ` Mark Brown
2011-09-08 18:35     ` Jassi Brar
2011-09-08 19:08       ` Mans Rullgard
2011-09-08 19:05   ` Mans Rullgard
2011-09-08 19:17     ` Jassi Brar
2011-09-08 19:26       ` Mans Rullgard
2011-09-08 20:28     ` Arnd Bergmann
2011-09-08 22:29       ` Mark Brown
2011-09-08 22:37         ` Russell King - ARM Linux
2011-09-08 22:47           ` Mark Brown
2011-09-08 23:01             ` Russell King - ARM Linux
2011-09-08 23:59               ` Mark Brown
2011-09-09  8:48                 ` Jassi Brar
2011-09-09  9:41                 ` Russell King - ARM Linux
2011-09-09 16:11                   ` Mark Brown
2011-09-09 19:01                     ` Russell King - ARM Linux [this message]
2011-09-09 19:30                       ` Mark Brown
2011-09-09 20:56                         ` Russell King - ARM Linux
2011-09-10 20:37                           ` Arnd Bergmann
2011-09-10 21:43                             ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110909190134.GA14520@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).