From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Add platform driver support to the CS890x driver
Date: Tue, 13 Sep 2011 09:46:26 +0200 [thread overview]
Message-ID: <20110913074626.GM28624@pengutronix.de> (raw)
In-Reply-To: <20110913074424.GY31404@pengutronix.de>
Hello,
On Tue, Sep 13, 2011 at 09:44:24AM +0200, Sascha Hauer wrote:
> On Wed, Sep 07, 2011 at 02:50:47PM +0200, Uwe Kleine-K?nig wrote:
> > > + printk(KERN_WARNING
> > > + DRV_NAME
> > > + ": memory and/or interrupt resource missing.\n");
> > I'd prefer you do:
> >
> > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> >
> > at the top of the driver and then just use:
> >
> > pr_warning("memory and/or interrupt resource missing\m");
>
> Why not use dev_warn??
Yeah, that works, too.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2011-09-13 7:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 10:22 [PATCH] Add platform driver support to the CS890x driver Jaccon Bastiaansen
2011-09-07 12:50 ` Uwe Kleine-König
2011-09-10 11:37 ` Jaccon Bastiaansen
2011-09-10 14:12 ` Uwe Kleine-König
2011-09-11 17:34 ` Jaccon Bastiaansen
2011-09-11 18:53 ` Uwe Kleine-König
2011-09-12 10:52 ` Jaccon Bastiaansen
2011-09-12 12:30 ` Uwe Kleine-König
[not found] ` <20110928083048.GA15311@glitch.intra.local>
2011-09-30 9:01 ` Jaccon Bastiaansen
2011-10-01 17:13 ` Russell King - ARM Linux
2011-10-12 14:28 ` Domenico Andreoli
2011-09-13 7:44 ` Sascha Hauer
2011-09-13 7:46 ` Uwe Kleine-König [this message]
2011-09-27 18:27 ` [PATCH V2] " Jaccon Bastiaansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110913074626.GM28624@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).