linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v15 06/12] OMAP: dmtimer: switch-over to platform device driver
Date: Wed, 14 Sep 2011 14:45:33 -0700	[thread overview]
Message-ID: <20110914214533.GA30941@atomide.com> (raw)
In-Reply-To: <1315516098-29761-7-git-send-email-tarun.kanti@ti.com>

Hi,

* Tarun Kanti DebBarma <tarun.kanti@ti.com> [110908 13:36]:
> Register timer devices by going through hwmod database using
> hwmod API. The driver probes each of the registered devices.
> Functionality which are already performed by hwmod framework
> are removed from timer code. New set of timers present on
> OMAP4 are now supported.

Adding the support for the different offsets on some omap4
timers should be a separate patch.

Also, as we don't need the support for different register offsets
for the first two omap4 timers, please rather implement support
for the new timers and the timeouts directly in plat-omap/dmtimer.c.

That way we can still keep the minimal timer support simple
for clocksource and clockevent. Of course this means that we'll
be only supporting the first two timers as system timers on
omap4, but that's fine.
 
>  static inline u32 __omap_dm_timer_read(void __iomem *base, u32 reg,
> -						int posted)
> +						int posted, u8 func_offset)
>  {
>  	if (posted)
> -		while (__raw_readl(base + (OMAP_TIMER_WRITE_PEND_REG & 0xff))
> +		while (__raw_readl(base +
> +			((OMAP_TIMER_WRITE_PEND_REG + func_offset) & 0xff))
>  				& (reg >> WPSHIFT))
>  			cpu_relax();
>  
> @@ -264,10 +263,11 @@ static inline u32 __omap_dm_timer_read(void __iomem *base, u32 reg,
>  }
>  
>  static inline void __omap_dm_timer_write(void __iomem *base, u32 reg, u32 val,
> -						int posted)
> +						int posted, u8 func_offset)
>  {
>  	if (posted)
> -		while (__raw_readl(base + (OMAP_TIMER_WRITE_PEND_REG & 0xff))
> +		while (__raw_readl(base +
> +			((OMAP_TIMER_WRITE_PEND_REG + func_offset) & 0xff))
>  				& (reg >> WPSHIFT))
>  			cpu_relax();

Otherwise our inline functions just get too messed up with these func_offset
hacks. These need to be minimal as they're being called contantly for the
system timers. We can still recycle the inline functions if we pass the
correct WRITE_PEND_REG to them instead of the func_offset.

Regards,

Tony 

  reply	other threads:[~2011-09-14 21:45 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-08 21:08 [PATCH v15 00/12] OMAP: dmtimer: adaptation to platform_driver Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 01/12] OMAP2+: dmtimer: add device names to flck nodes Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 02/12] OMAP4: hwmod data: add dmtimer version information Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 03/12] OMAP1: dmtimer: conversion to platform devices Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 04/12] OMAP2+: dmtimer: convert " Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 05/12] OMAP: dmtimer: platform driver Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 06/12] OMAP: dmtimer: switch-over to platform device driver Tarun Kanti DebBarma
2011-09-14 21:45   ` Tony Lindgren [this message]
2011-09-14 22:24     ` Tony Lindgren
2011-09-15  5:42     ` DebBarma, Tarun Kanti
2011-09-15  8:46       ` Mohammed, Afzal
2011-09-15 16:58         ` Tony Lindgren
2011-09-15 17:05           ` Tony Lindgren
2011-09-16  3:54             ` DebBarma, Tarun Kanti
2011-09-16  9:30               ` DebBarma, Tarun Kanti
2011-09-17  1:35                 ` [PATCH] ARM: OMAP: Add support for dmtimer v2 ip (Re: [PATCH v15 06/12] OMAP: dmtimer: switch-over to platform device driver) Tony Lindgren
2011-09-18 12:27                   ` DebBarma, Tarun Kanti
2011-09-19 17:43                     ` Tony Lindgren
2011-09-19  4:06                   ` Pedanekar, Hemant
2011-09-19 17:40                     ` Tony Lindgren
2011-09-19 23:41                       ` Pedanekar, Hemant
2011-09-19  5:22                   ` Mohammed, Afzal
2011-09-19 17:43                     ` Tony Lindgren
2011-09-08 21:08 ` [PATCH v15 07/12] OMAP: dmtimer: pm_runtime support Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 08/12] OMAP: dmtimer: add timeout to low-level routines Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 09/12] OMAP: dmtimer: mark clocksource and clockevent timers reserved Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 10/12] OMAP: dmtimer: low-power mode support Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 11/12] OMAP: dmtimer: extend spinlock to exported APIs Tarun Kanti DebBarma
2011-09-13 23:15   ` Tony Lindgren
2011-09-14  4:58     ` DebBarma, Tarun Kanti
2011-09-08 21:08 ` [PATCH v15 12/12] OMAP: dmtimer: add error handling to export APIs Tarun Kanti DebBarma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110914214533.GA30941@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).