From mboxrd@z Thu Jan 1 00:00:00 1970 From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD) Date: Thu, 15 Sep 2011 15:23:01 +0200 Subject: [PATCH v2] [media] at91: add code to initialize and manage the ISI_MCK for Atmel ISI driver. In-Reply-To: <4E668BBF.4020600@gmail.com> References: <1315288601-22384-1-git-send-email-josh.wu@atmel.com> <20110906200512.GA15083@game.jcrosoft.org> <4E668BBF.4020600@gmail.com> Message-ID: <20110915132301.GK28104@game.jcrosoft.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 23:08 Tue 06 Sep , Sylwester Nawrocki wrote: > On 09/06/2011 10:05 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > >> I'm not entirely sure on this one, but as we had a similar situation with > >> clocks, we decided to extablish the clock hierarchy in the board code, and > >> only deal with the actual device clocks in the driver itself. I.e., we > >> moved all clk_set_parent() and setting up the parent clock into the board. > >> And I do think, this makes more sense, than doing this in the driver, not > >> all users of this driver will need to manage the parent clock, right? > > > > I don't like to manage the clock in the board except if it's manadatory otherwise > > we manage this at soc level > > > > the driver does not have to manage the clock hierachy or detail implementation > > but manage the clock enable/disable and speed depending on it's need > > We had a similar problem in the past and we ended up having the boot loader > setting up the parent clock for the device clock. The driver only controls clock > gating and sets its clock frequency based on an internal IP version information, > derived from the SoC revision. sorry NACK I do not want to rely on bootloader when we will have the DT we will pass it via it right now we need find an other generic way Best Regards, J.