[PATCH v2] spi/imx: Fix spi-imx when the hardware SPI chipselects are used

Grant Likely
2011-09-15T21:01:46Z

On Thu, Sep 15, 2011 at 10:19:09PM +0200, Uwe Kleine-K?nig wrote:
> Hello again,
>
> On Thu, Sep 15, 2011 at 09:52:43PM +0200, Uwe Kleine-K?nig wrote:
> > diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
> > index 8ac6542..fa594d6 100644
> > --- a/drivers/spi/spi-imx.c
> > +++ b/drivers/spi/spi-imx.c
> > @@ -786,9 +786,11 @@ static int __devinit spi_imx_probe(struct platform_device *pdev)
> > int cs_gpio = of_get_named_gpio(np, "cs-gpios", i);
> > if (cs_gpio < 0)
> > cs_gpio = mxc_platform_info->chipselect[i];
> > +
> > + spi_imx->chipselect[i] = cs_gpio;
> > if (cs_gpio < 0)
> > continue;
> > - spi_imx->chipselect[i] = cs_gpio;
> > +
> > ret = gpio_request(spi_imx->chipselect[i], DRIVER_NAME);
> > if (ret) {
> > while (i > 0) {
> Having said that I wonder how to specify to use an internal chipselect
> via DT?

It would be done with a blank gpio specifier which is supported by the GPIO binding.

g.