From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: kdump: copy kernel relocation code at the kexec prepare stage
Date: Mon, 19 Sep 2011 15:41:37 +0100 [thread overview]
Message-ID: <20110919144136.GT16381@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <53612FE6B944314AAADB181E45A45B641387938501@sc-vexch3.marvell.com>
On Mon, Sep 19, 2011 at 07:11:59AM -0700, Lei Wen wrote:
> Thanks for this reminding!
> Then how about add flush_icache_range at the end of machine_kexec_prepare?
> Could it be acceptable?
I think it should be done.
> Also with this change, do we still need flush icache at the end stage of
> machine_kexec?
You need to use flush_icache_range() whenever you write _instructions_
to an area of memory which you intend to execute. If you're not writing
instructions, you shouldn't use flush_icache_range().
next prev parent reply other threads:[~2011-09-19 14:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-16 5:32 [PATCH] ARM: kdump: copy kernel relocation code at the kexec prepare stage Lei Wen
2011-09-16 5:45 ` Simon Horman
2011-09-17 13:58 ` Lei Wen
2011-09-19 2:29 ` Lei Wen
2011-09-19 12:20 ` Russell King - ARM Linux
2011-09-19 14:11 ` Lei Wen
2011-09-19 14:41 ` Russell King - ARM Linux [this message]
2011-09-20 12:00 ` [PATCH V2] " Lei Wen
2011-09-20 22:43 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110919144136.GT16381@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).