linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/7] Add L2 cache cleaning to generic CPU suspend
Date: Tue, 20 Sep 2011 12:45:27 +0100	[thread overview]
Message-ID: <20110920114527.GA15663@e102568-lin.cambridge.arm.com> (raw)
In-Reply-To: <20110919163741.GE16591@n2100.arm.linux.org.uk>

On Mon, Sep 19, 2011 at 05:37:41PM +0100, Russell King - ARM Linux wrote:
> This is a re-post of the previous patch series, but with an additional
> TLB flush to ensure that hte global TLB entry in the page tables is
> flushed out.  This is a flush of all TLB entries, but it could probably
> be more targetted if we need to.
> 
> Original cover mail follows:
> 
> Some systems (such as OMAP) preserve the L2 cache across a suspend/
> resume cycle.  This means they do not perform L2 cache maintanence
> in their suspend finisher function.
> 
> However, the side effect is that the saved CPU state is not readable
> by the resume code because it is sitting in the L2 cache.
> 
> This patch series adds L2 cache cleaning to the generic CPU suspend/
> resume support code, making it possible to use this on systems with
> L2 cache enabled without having to clean/invalidate the entire L2
> cache.
> 
> We also add a separate page table, allocated at boot time, for the
> resume process to use so we don't have to fiddle about with tweaking
> entries in the current processes page table.  Moreover, the current
> processes page table may be in use by another CPU in the system if
> these paths are used from cpuidle or hotplug, so changing the page
> table is technically unsound.
> 
> Overall, this makes it possible for OMAP4 systems to use this code.
> 
> 

Thanks Russell for this.
As expected, it does fix the issue. Tested on ARM internal platforms
and Origen with both suspend and cpuidle. So, on the whole series:

Tested-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>

      parent reply	other threads:[~2011-09-20 11:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-19 16:37 [PATCH 0/7] Add L2 cache cleaning to generic CPU suspend Russell King - ARM Linux
2011-09-19 16:38 ` [PATCH 1/7] ARM: pm: force non-zero return value from __cpu_suspend when aborting Russell King - ARM Linux
2011-09-19 16:39 ` [PATCH 2/7] ARM: pm: preallocate a page table for suspend/resume Russell King - ARM Linux
2011-09-19 16:39 ` [PATCH 3/7] ARM: pm: only use preallocated page table during resume Russell King - ARM Linux
2011-09-19 16:39 ` [PATCH 4/7] ARM: pm: no need to save/restore context ID register Russell King - ARM Linux
2011-09-19 16:40 ` [PATCH 5/7] ARM: pm: get rid of cpu_resume_turn_mmu_on Russell King - ARM Linux
2011-09-19 16:40 ` [PATCH 6/7] ARM: pm: convert some assembly to C Russell King - ARM Linux
2011-09-19 16:40 ` [PATCH 7/7] ARM: pm: add L2 cache cleaning for suspend Russell King - ARM Linux
2011-09-20  3:47 ` [PATCH 0/7] Add L2 cache cleaning to generic CPU suspend Shawn Guo
2011-09-20  7:46   ` Russell King - ARM Linux
2011-09-20  8:04     ` Shawn Guo
2011-09-20 10:44 ` Santosh
2011-09-20 11:45 ` Lorenzo Pieralisi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110920114527.GA15663@e102568-lin.cambridge.arm.com \
    --to=lorenzo.pieralisi@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).