From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/3] net/fec: add imx6q enet support
Date: Wed, 21 Sep 2011 14:26:33 +0200 [thread overview]
Message-ID: <20110921122633.GH1966@pengutronix.de> (raw)
In-Reply-To: <20110921115821.GF28907@S2100-06.ap.freescale.net>
On Wed, Sep 21, 2011 at 07:58:22PM +0800, Shawn Guo wrote:
> On Wed, Sep 21, 2011 at 01:32:39PM +0200, Wolfram Sang wrote:
> >
> > > +/* Controller has GBIT support */
> > > +#define FEC_QUIRK_HAS_GBIT (1 << 3)
> >
> > Heh, this is not really a quirk, but a nice feature :) I think we can
> > drop QUIRK if we see driver_data more as "flags" instead of "quirks"?
> > Minor, though.
> >
> As you have told, all these FEC_QUIRK_* are just flags actually. The
> name was pick to keep the consistency, as they are all used for the
> same purpose.
I think introducing FEC_FEATURE_HAS_GBIT would be consistent enough, but
as I said, I don't mind much.
> > Also minor, but the patch looks like a good oportunity to start
> > replacing magic values with proper defines?
> >
> There are already so many magic numbers. It really deserves a separated
> patch.
That is the other possibility, yes. Which sadly never happened.
> I heard that Uwe had a plan to do that some time ago. He gives up
> now? :)
I don't know about this case. Also, it is not about blaming here. It is
totally okay for you to say that you don't want to change your patch to
start replacing the magic values. I mainly wanted to point out the
oportunity here.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110921/780cd0f7/attachment.sig>
prev parent reply other threads:[~2011-09-21 12:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 11:10 [PATCH v2 0/3] add fec support for imx6q Shawn Guo
2011-09-21 11:10 ` [PATCH v2 1/3] net/fec: change phy-reset-gpio request warning to debug message Shawn Guo
2011-09-21 11:25 ` Wolfram Sang
2011-09-21 12:03 ` Shawn Guo
2011-09-21 12:11 ` Wolfram Sang
2011-09-21 12:44 ` Shawn Guo
2011-09-21 12:59 ` Wolfram Sang
2011-09-21 13:18 ` Shawn Guo
2011-09-21 11:10 ` [PATCH v2 2/3] net/fec: fix fec1 check in fec_enet_mii_init() Shawn Guo
2011-09-21 11:10 ` [PATCH v2 3/3] net/fec: add imx6q enet support Shawn Guo
2011-09-21 11:07 ` Fabio Estevam
2011-09-21 11:28 ` Shawn Guo
2011-09-21 11:32 ` Wolfram Sang
2011-09-21 11:58 ` Shawn Guo
2011-09-21 12:26 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110921122633.GH1966@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).