linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 26/26] gpio/omap: add dbclk aliases for all gpio modules
Date: Wed, 21 Sep 2011 08:13:13 -0700	[thread overview]
Message-ID: <20110921151313.GC2937@atomide.com> (raw)
In-Reply-To: <1315918979-26173-27-git-send-email-tarun.kanti@ti.com>

* Tarun Kanti DebBarma <tarun.kanti@ti.com> [110913 05:29]:
> Unless the dbclk aliases are assigned, clk_get(bank->dev, "dbclk")
> would not fetch the associated clock handle. As a result, we would
> not be able to turn on/off the debounce clock. This was preventing
> the gpio modules going to low power mode whenever dbclk is enabled.
> 
> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@ti.com>

Looks OK to me, Paul should ack this one also:

Acked-by: Tony Lindgren <tony@atomide.com>

> ---
>  arch/arm/mach-omap2/clock3xxx_data.c |    6 ++++++
>  arch/arm/mach-omap2/clock44xx_data.c |    6 ++++++
>  2 files changed, 12 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/clock3xxx_data.c b/arch/arm/mach-omap2/clock3xxx_data.c
> index ffd55b1..7238ec1 100644
> --- a/arch/arm/mach-omap2/clock3xxx_data.c
> +++ b/arch/arm/mach-omap2/clock3xxx_data.c
> @@ -3462,6 +3462,12 @@ static struct omap_clk omap3xxx_clks[] = {
>  	CLK("musb-am35x",	"fck",		&hsotgusb_fck_am35xx,	CK_AM35XX),
>  	CLK(NULL,	"hecc_ck",	&hecc_ck,	CK_AM35XX),
>  	CLK(NULL,	"uart4_ick",	&uart4_ick_am35xx,	CK_AM35XX),
> +	CLK("omap_gpio.1",	"dbclk",	&gpio1_dbck,	CK_3XXX),
> +	CLK("omap_gpio.2",	"dbclk",	&gpio2_dbck,	CK_3XXX),
> +	CLK("omap_gpio.3",	"dbclk",	&gpio3_dbck,	CK_3XXX),
> +	CLK("omap_gpio.4",	"dbclk",	&gpio4_dbck,	CK_3XXX),
> +	CLK("omap_gpio.5",	"dbclk",	&gpio5_dbck,	CK_3XXX),
> +	CLK("omap_gpio.6",	"dbclk",	&gpio6_dbck,	CK_3XXX),
>  };
>  
>  
> diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c
> index 2af0e3f..4986069 100644
> --- a/arch/arm/mach-omap2/clock44xx_data.c
> +++ b/arch/arm/mach-omap2/clock44xx_data.c
> @@ -3363,6 +3363,12 @@ static struct omap_clk omap44xx_clks[] = {
>  	CLK("usbhs-omap.0",	"usbhost_ick",		&dummy_ck,		CK_443X),
>  	CLK("usbhs-omap.0",	"usbtll_fck",		&dummy_ck,	CK_443X),
>  	CLK("omap_wdt",	"ick",				&dummy_ck,	CK_443X),
> +	CLK("omap_gpio.1",	"dbclk",	&gpio1_dbclk,	CK_443X),
> +	CLK("omap_gpio.2",	"dbclk",	&gpio2_dbclk,	CK_443X),
> +	CLK("omap_gpio.3",	"dbclk",	&gpio3_dbclk,	CK_443X),
> +	CLK("omap_gpio.4",	"dbclk",	&gpio4_dbclk,	CK_443X),
> +	CLK("omap_gpio.5",	"dbclk",	&gpio5_dbclk,	CK_443X),
> +	CLK("omap_gpio.6",	"dbclk",	&gpio6_dbclk,	CK_443X),
>  };
>  
>  int __init omap4xxx_clk_init(void)
> -- 
> 1.7.0.4
> 

  reply	other threads:[~2011-09-21 15:13 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-13 13:02 [PATCH v7 00/26] gpio/omap: driver cleanup and fixes Tarun Kanti DebBarma
2011-09-13 13:02 ` [PATCH v7 01/26] gpio/omap: remove dependency on gpio_bank_count Tarun Kanti DebBarma
2011-09-21 14:41   ` Tony Lindgren
2011-09-13 13:02 ` [PATCH v7 02/26] gpio/omap: use flag to identify wakeup domain Tarun Kanti DebBarma
2011-09-13 13:02 ` [PATCH v7 03/26] gpio/omap: make gpio_context part of gpio_bank structure Tarun Kanti DebBarma
2011-09-13 13:02 ` [PATCH v7 04/26] gpio/omap: fix pwrdm_post_transition call sequence Tarun Kanti DebBarma
2011-09-21 14:47   ` Tony Lindgren
2011-09-26 23:15   ` Kevin Hilman
2011-09-13 13:02 ` [PATCH v7 05/26] gpio/omap: handle save/restore context in GPIO driver Tarun Kanti DebBarma
2011-09-21 14:48   ` Tony Lindgren
2011-09-26 23:22   ` Kevin Hilman
2011-09-13 13:02 ` [PATCH v7 06/26] gpio/omap: make non-wakeup GPIO part of pdata Tarun Kanti DebBarma
2011-09-21 14:49   ` Tony Lindgren
2011-09-13 13:02 ` [PATCH v7 07/26] gpio/omap: avoid cpu checks during module ena/disable Tarun Kanti DebBarma
2011-09-21 14:49   ` Tony Lindgren
2011-09-13 13:02 ` [PATCH v7 08/26] gpio/omap: further cleanup using wkup_en register Tarun Kanti DebBarma
2011-09-21 14:49   ` Tony Lindgren
2011-09-13 13:02 ` [PATCH v7 09/26] gpio/omap: use level/edge detect reg offsets Tarun Kanti DebBarma
2011-09-21 14:55   ` Tony Lindgren
2011-09-13 13:02 ` [PATCH v7 10/26] gpio/omap: remove hardcoded offsets in context save/restore Tarun Kanti DebBarma
2011-09-21 14:55   ` Tony Lindgren
2011-09-13 13:02 ` [PATCH v7 11/26] gpio/omap: cleanup set_gpio_triggering function Tarun Kanti DebBarma
2011-09-21 14:55   ` Tony Lindgren
2011-09-13 13:02 ` [PATCH v7 12/26] gpio/omap: cleanup omap_gpio_mod_init function Tarun Kanti DebBarma
2011-09-21 14:56   ` Tony Lindgren
2011-09-13 13:02 ` [PATCH v7 13/26] gpio/omap: use pinctrl offset instead of macro Tarun Kanti DebBarma
2011-09-21 14:56   ` Tony Lindgren
2011-09-21 15:03   ` Tony Lindgren
2011-09-13 13:02 ` [PATCH v7 14/26] gpio/omap: remove unnecessary bit-masking for read access Tarun Kanti DebBarma
2011-09-14 11:19   ` Sergei Shtylyov
2011-09-14 13:08     ` DebBarma, Tarun Kanti
2011-09-13 13:02 ` [PATCH v7 15/26] gpio/omap: remove bank->method & METHOD_* macros Tarun Kanti DebBarma
2011-09-21 15:05   ` Tony Lindgren
2011-09-13 13:02 ` [PATCH v7 16/26] gpio/omap: fix bankwidth for OMAP7xx MPUIO Tarun Kanti DebBarma
2011-09-21 15:05   ` Tony Lindgren
2011-09-13 13:02 ` [PATCH v7 17/26] gpio/omap: use pm-runtime framework Tarun Kanti DebBarma
2011-09-13 13:02 ` [PATCH v7 18/26] gpio/omap: optimize suspend and resume functions Tarun Kanti DebBarma
2011-09-13 13:02 ` [PATCH v7 19/26] gpio/omap: cleanup prepare_for_idle and resume_after_idle Tarun Kanti DebBarma
2011-09-13 13:02 ` [PATCH v7 20/26] gpio/omap: skip operations in runtime callbacks Tarun Kanti DebBarma
2011-09-13 13:02 ` [PATCH v7 21/26] gpio/omap: remove omap_gpio_save_context overhead Tarun Kanti DebBarma
2011-09-13 13:02 ` [PATCH v7 22/26] gpio/omap: save and restore debounce registers Tarun Kanti DebBarma
2011-09-13 13:02 ` [PATCH v7 23/26] gpio/omap: enable irq at the end of all configuration in restore Tarun Kanti DebBarma
2011-09-13 13:02 ` [PATCH v7 24/26] gpio/omap: restore OE only after setting the output level Tarun Kanti DebBarma
2011-09-13 13:02 ` [PATCH v7 25/26] gpio/omap: handle set_dataout reg capable IP on restore Tarun Kanti DebBarma
2011-09-13 13:02 ` [PATCH v7 26/26] gpio/omap: add dbclk aliases for all gpio modules Tarun Kanti DebBarma
2011-09-21 15:13   ` Tony Lindgren [this message]
2011-09-22 15:27 ` [PATCH v7 00/26] gpio/omap: driver cleanup and fixes DebBarma, Tarun Kanti
2011-09-22 20:36   ` Kevin Hilman
2011-09-23  4:24     ` DebBarma, Tarun Kanti
2011-09-22 23:57 ` Kevin Hilman
2011-09-24  3:56   ` DebBarma, Tarun Kanti
2011-09-24  8:50     ` Santosh Shilimkar
2011-09-24 10:41       ` DebBarma, Tarun Kanti
2011-09-26 18:39         ` Kevin Hilman
2011-09-26 22:10           ` DebBarma, Tarun Kanti
2011-09-26 22:59             ` Kevin Hilman
2011-09-26 23:10         ` Kevin Hilman
2011-09-27 14:31           ` DebBarma, Tarun Kanti
2011-09-27 16:22             ` Kevin Hilman
2011-09-27 23:42               ` DebBarma, Tarun Kanti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110921151313.GC2937@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).