From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/3] TI814X: Create board support and enable build for TI8148 EVM
Date: Wed, 21 Sep 2011 13:48:26 -0700 [thread overview]
Message-ID: <20110921204826.GK2937@atomide.com> (raw)
In-Reply-To: <1316626754-5764-1-git-send-email-hemantp@ti.com>
* Hemant Pedanekar <hemantp@ti.com> [110921 10:05]:
> +
> +static struct omap_board_config_kernel ti8148_evm_config[] __initdata = {
> +};
> +
> +static void __init ti8148_evm_init(void)
> +{
> + omap_serial_init();
> + omap_board_config = ti8148_evm_config;
> + omap_board_config_size = ARRAY_SIZE(ti8148_evm_config);
> +}
> +
> +static void __init ti8148_evm_map_io(void)
> +{
> + omap2_set_globals_ti81xx();
> + omapti81xx_map_common_io();
> +}
Hmm I guess we still have board specific map_io in board-ti8668evm.c
also. Those would be better replaced with ti81xx_map_io in
mach-omap2/common.c. Care to take a look at that?
> +MACHINE_START(TI8148EVM, "ti8148evm")
> + /* Maintainer: Texas Instruments */
> + .atag_offset = 0x100,
> + .map_io = ti8148_evm_map_io,
> + .init_early = ti81xx_init_early,
> + .init_irq = ti81xx_init_irq,
> + .timer = &omap3_timer,
> + .init_machine = ti8148_evm_init,
> +MACHINE_END
Please add this all to board-ti8168evm.c instead of adding a new
board-*.c file. With the upcoming device tree conversion most of
these will disappear anyways.
Regards,
Tony
next prev parent reply other threads:[~2011-09-21 20:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 17:39 [PATCH v2 3/3] TI814X: Create board support and enable build for TI8148 EVM Hemant Pedanekar
2011-09-21 20:48 ` Tony Lindgren [this message]
2011-09-22 0:41 ` Pedanekar, Hemant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110921204826.GK2937@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox