linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] i2c-tegra: Use the suspend_noirq/resume_noirq not suspend/resume
Date: Thu, 22 Sep 2011 19:13:13 +0100	[thread overview]
Message-ID: <20110922181313.GG5173@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110922180335.GQ17168@ponder.secretlab.ca>

On Thu, Sep 22, 2011 at 12:03:35PM -0600, Grant Likely wrote:
> On Thu, Sep 22, 2011 at 11:51:32AM -0600, Stephen Warren wrote:

> > * Implement an explicit dependency management system within the kernel for
> >   device suspend/resume, such that I2C bus would not be suspended before
> >   the sound card that requires it. It is reported that Linus rejected this
> >   proposal since he wanted suspend ordering to be based on probe ordering.

> This really should be revisted.  That was in the context of full
> system suspend, but we're now in a world of runtime suspend which
> absolutely does need dependency tracking or reference counting to get
> the ordering right.

FWIW this was one of the bigger issues in the PM miniconference in Santa
Rosa, though a lot of the discission involved explaining the issues to
some of the x86 guys and there wasn't mssive progress on solutions.

> > * Enhance device probing such that the ASoC sound card device could defer
> >   its probing until all required resources were available. This would
> >   then cause the overall sound card suspend to occur at an appropriate early
> >   time. Grant Likely was reported to have been working towards this goal.

> Yes, I'll send you my current patch for you to look at.  One of the
> engineers from Linaro is going to be pushing that patch set forward.
> However, I don't know if it helps with this problem because I believe
> that the suspend order is based on the implicit probe order of
> devices, but my patch allows drivers to cause the probe order to get
> rearranged at runtime.  I don't believe there is a global list showing
> the order that devices successfully got probed, but I may be wrong
> here.

Yes, I'm not convinced it'll change anything here.  Though I guess it
should be a simple matter of programming to move devices around the list
depending on when they probe.

      reply	other threads:[~2011-09-22 18:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-22 17:51 [PATCH v2] i2c-tegra: Use the suspend_noirq/resume_noirq not suspend/resume Stephen Warren
2011-09-22 18:03 ` Grant Likely
2011-09-22 18:13   ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110922181313.GG5173@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).