From: jamie@jamieiles.com (Jamie Iles)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: gic: add OF based initialization
Date: Mon, 26 Sep 2011 23:00:13 +0100 [thread overview]
Message-ID: <20110926220013.GF9194@gallagher> (raw)
In-Reply-To: <4E80EF61.2000509@gmail.com>
On Mon, Sep 26, 2011 at 04:32:17PM -0500, Rob Herring wrote:
> On 09/26/2011 04:11 PM, Jamie Iles wrote:
> > On Mon, Sep 26, 2011 at 03:49:11PM -0500, Rob Herring wrote:
> >> On 09/26/2011 02:57 PM, Jamie Iles wrote:
> >>> Hi Rob,
> >>>
> >>> On Tue, Sep 20, 2011 at 03:24:04PM -0500, Rob Herring wrote:
> >>> [...]
> >>>> +int __init gic_of_init(struct device_node *node, struct device_node *parent)
> >>>> +{
> >>>> + void __iomem *cpu_base;
> >>>> + void __iomem *dist_base;
> >>>> + int irq;
> >>>> + struct irq_domain *domain = &gic_data[gic_cnt].domain;
> >>>> +
> >>>> + if (WARN_ON(!node))
> >>>> + return -ENODEV;
> >>>> +
> >>>> + dist_base = of_iomap(node, 0);
> >>>> + WARN(!dist_base, "unable to map gic dist registers\n");
> >>>> +
> >>>> + cpu_base = of_iomap(node, 1);
> >>>> + WARN(!cpu_base, "unable to map gic cpu registers\n");
> >>>> +
> >>>> + domain->nr_irq = gic_irq_count(dist_base);
> >>>> + /* subtract off SGIs. Also subtract off PPIs for secondary GICs */
> >>>> + if (parent)
> >>>> + domain->nr_irq -= 32;
> >>>> + else
> >>>> + domain->nr_irq -= 16;
> >>>> +
> >>>> + domain->irq_base = irq_alloc_descs(-1, 16, domain->nr_irq, numa_node_id());
> >>>
> >>> The way I understand irq_alloc_descs() (probably not very well) is that
> >>> having the irq parameter < 0 and the from parameter 16 means that it
> >>> needs to find domain->nr_irq descs starting from at least 16. But if
> >>> the base is greater than 16, does this still work with the gic entry
> >>> macros as they are?
> >>
> >> No, but that would only happen if a platform calls irq_alloc_descs prior
> >> to this code. The root controller must be initialized first (for other
> >> reasons as well). There are no calls to irq_alloc_descs in arch/arm.
> >>
> >> With the MULTI_IRQ GIC support Marc Z is working on, we could make the
> >> GIC irq mapping be completely dynamic. Although, there's probably not
> >> much reason to do so for the root controller.
> >
> > OK, that makes sense. I think that if you were to do
> > irq_alloc_descs(16, 16, domain->nr_irqs, num_node_id()) then that will
> > guarantee the descriptors start from 16 (if they are available) which is
> > probably nicer.
> >
> That would break secondary GICs though as it would always fail. For
> secondary GIC, we skip SGIs and PPIs and allocate the first available
> block of irq_desc's.
Ahh, OK that makes sense. Thanks for the explanation Rob! That'll
hopefully help me with a common VIC binding.
Jamie
next prev parent reply other threads:[~2011-09-26 22:00 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 20:24 [PATCH 0/3] GIC OF bindings Rob Herring
2011-09-20 20:24 ` [PATCH 1/3] of/irq: of_irq_find_parent: check for parent equal to child Rob Herring
2011-09-20 21:01 ` Grant Likely
2011-09-20 20:24 ` [PATCH 2/3] of/irq: introduce of_irq_init Rob Herring
2011-09-20 23:00 ` Grant Likely
2011-09-21 10:01 ` Jamie Iles
2011-09-23 2:21 ` [PATCH v3] " Rob Herring
2011-09-23 5:14 ` Grant Likely
2011-09-26 19:24 ` [PATCH v4] " Rob Herring
2011-09-27 1:53 ` Grant Likely
2011-09-27 13:03 ` Rob Herring
2011-09-27 21:24 ` Grant Likely
2011-09-20 20:24 ` [PATCH 3/3] ARM: gic: add OF based initialization Rob Herring
2011-09-20 23:08 ` Grant Likely
2011-09-21 1:54 ` Rob Herring
2011-09-21 17:15 ` Cousson, Benoit
2011-09-21 17:55 ` Rob Herring
2011-09-21 19:28 ` Cousson, Benoit
2011-09-21 20:27 ` Cousson, Benoit
2011-09-26 19:57 ` Jamie Iles
2011-09-26 20:49 ` Rob Herring
2011-09-26 21:11 ` Jamie Iles
2011-09-26 21:32 ` Rob Herring
2011-09-26 22:00 ` Jamie Iles [this message]
2011-09-26 22:29 ` Jamie Iles
2011-09-21 2:49 ` [PATCH 0/3] GIC OF bindings David Miller
2011-09-21 4:14 ` Grant Likely
2011-09-21 4:58 ` Mitch Bradley
2011-09-21 5:21 ` David Miller
2011-09-21 7:11 ` Mitch Bradley
2011-09-21 5:16 ` Segher Boessenkool
2011-09-21 9:43 ` Shawn Guo
-- strict thread matches above, loose matches on Subject: below --
2011-09-30 19:27 Rob Herring
2011-09-30 19:28 ` [PATCH 3/3] ARM: gic: add OF based initialization Rob Herring
2011-10-04 23:44 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110926220013.GF9194@gallagher \
--to=jamie@jamieiles.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).