From mboxrd@z Thu Jan  1 00:00:00 1970
From: s.hauer@pengutronix.de (Sascha Hauer)
Date: Wed, 28 Sep 2011 08:29:45 +0200
Subject: [PATCH v3 4/6] arm/imx6q: add smp and cpu hotplug support
In-Reply-To: <20110927151546.GF17997@S2100-06.ap.freescale.net>
References: <1317021651-17359-1-git-send-email-shawn.guo@linaro.org>
	<1317021651-17359-5-git-send-email-shawn.guo@linaro.org>
	<20110926110634.GR31404@pengutronix.de>
	<20110927134401.GE17997@S2100-06.ap.freescale.net>
	<20110927151546.GF17997@S2100-06.ap.freescale.net>
Message-ID: <20110928062945.GC14191@pengutronix.de>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Tue, Sep 27, 2011 at 11:15:47PM +0800, Shawn Guo wrote:
> > 
> > I do not want to add mxc_cpu_type and cpu_is_mx6q() stuff, so I intend
> > to remove early_initcall there, and let imx31/35_soc_init() explicitly
> > calls mxc_init_l2x0().
> > 
> I'm changing my mind (so quickly).  It turns out we will fall into a
> number of other traps if we build imx6q with imx3 without mxc_cpu_type
> set up for imx6q, arch_idle(), __imx_ioremap(), etc.  So for now, I
> want to add mxc_cpu_type for imx6q to cooperate with all these traps.

I'm fine with reducing the usage of cpu_is_* macros up to the point when
we don't need them anymore. But as you already found out, it's better to
do this seperately.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |