From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: localtimer: add header linux/errno.h explicitly
Date: Sat, 1 Oct 2011 17:37:21 +0100 [thread overview]
Message-ID: <20111001163721.GJ11710@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20110930020208.GA19807@S2100-06.ap.freescale.net>
On Fri, Sep 30, 2011 at 10:02:10AM +0800, Shawn Guo wrote:
> Hi Russell,
>
> Do you have any comment on this patch? Otherwise, I will put it into
> patch tracker.
Only that the include should be towards the top of the file rather
than conditionally included. That avoids potential surprise compile
errors caused by changes in configuration. (Ok, you may argue that
they shouldn't happen but with the amount of includes we have it's
very difficult to ensure that everything explicitly includes everything
it actually needs.)
next prev parent reply other threads:[~2011-10-01 16:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 17:22 [PATCH] ARM: localtimer: add header linux/errno.h explicitly Shawn Guo
2011-09-30 2:02 ` Shawn Guo
2011-10-01 16:37 ` Russell King - ARM Linux [this message]
2011-10-02 8:20 ` [PATCH v2] " Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111001163721.GJ11710@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).