From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] ASoC: samsung: fix Kconfig dependencies
Date: Sun, 2 Oct 2011 21:47:30 +0100 [thread overview]
Message-ID: <20111002204729.GC5811@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1317587284-2776-6-git-send-email-arnd@arndb.de>
On Sun, Oct 02, 2011 at 10:28:03PM +0200, Arnd Bergmann wrote:
> config SND_SAMSUNG_AC97
> tristate
> + depends on SND_SOC_ALL_CODECS=n || SND_SOC_ALL_CODECS
> select SND_SOC_AC97_BUS
No, I'm not sure what the problem you're trying to fix here but this
looks pretty terrible. SND_SOC_ALL_CODECS is a debugging tool for build
coverage, we shouldn't be restricting actual useful drivers based on it.
What is the intention of this change and why does it only apply to the
Samsung platform? It all looks very magic.
> config SND_SOC_SAMSUNG_SMDK_WM8994
> tristate "SoC I2S Audio support for WM8994 on SMDK"
> depends on SND_SOC_SAMSUNG && (MACH_SMDKV310 || MACH_SMDKC210)
> + depends on MFD_WM8994
> select SND_SOC_WM8994
This is non-idiomatic - we always select the CODEC drivers rather than
depending on them for usability.
Please also split the two changes you're doing here into separate
patches. I might've applied the wm8994 bit but it's squashed in with
the AC'97 change...
next prev parent reply other threads:[~2011-10-02 20:47 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-02 20:27 [PATCH 0/6] ASoC fixes from ARM randconfig builds Arnd Bergmann
2011-10-02 20:27 ` [PATCH 1/6] ASoC: codecs/wm8682: use __devexit_p Arnd Bergmann
2011-10-02 20:36 ` Mark Brown
2011-10-02 20:28 ` [PATCH 2/6] ASoC: codecs: AK4641 depends on GPIOLIB Arnd Bergmann
2011-10-02 20:41 ` Mark Brown
2011-10-02 20:53 ` Arnd Bergmann
2011-10-02 21:27 ` Mark Brown
2011-10-03 10:59 ` Arnd Bergmann
2011-10-03 13:45 ` Russell King - ARM Linux
2011-10-03 14:35 ` [alsa-devel] " Mark Brown
2011-10-03 14:47 ` Arnd Bergmann
2011-10-03 15:20 ` Mark Brown
2011-10-03 16:19 ` Arnd Bergmann
2011-10-03 16:34 ` Mark Brown
2011-10-02 20:28 ` [PATCH 3/6] ASoC: imx: eukrea_tlv320 needs i2c Arnd Bergmann
2011-10-02 20:49 ` Mark Brown
2011-10-02 20:28 ` [PATCH 4/6] ASoC: sh: use correct __iomem annotations Arnd Bergmann
2011-10-02 20:50 ` Mark Brown
2011-10-02 21:20 ` Arnd Bergmann
2011-10-02 20:28 ` [PATCH 5/6] ASoC: samsung: fix Kconfig dependencies Arnd Bergmann
2011-10-02 20:47 ` Mark Brown [this message]
2011-10-02 21:14 ` Arnd Bergmann
2011-10-02 21:29 ` Mark Brown
2011-10-03 6:48 ` [alsa-devel] " Sangbeom Kim
2011-10-03 11:50 ` Arnd Bergmann
2011-10-03 12:07 ` Mark Brown
2011-10-03 13:43 ` [PATCH 5/6] ASoC: samsung: wm8994 depends on mfd_wm8994 Arnd Bergmann
2011-10-03 14:08 ` Mark Brown
2011-10-03 14:35 ` [PATCH v3] " Arnd Bergmann
2011-10-03 14:40 ` Mark Brown
2011-10-02 20:28 ` [PATCH 6/6] ASoC: samsung: add missing __devexit_p() annotations Arnd Bergmann
2011-10-02 20:48 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111002204729.GC5811@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).