From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 15/30] usb/musb: use a Kconfig choice to pick the right DMA method
Date: Mon, 3 Oct 2011 01:10:51 +0300 [thread overview]
Message-ID: <20111002221050.GA25790@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <1546914.88vcgxkfJf@wuerfel>
Hi,
On Sun, Oct 02, 2011 at 09:44:26PM +0200, Arnd Bergmann wrote:
> > that's how MUSB works now and that's what I have been discussing with
> > Alan Stern for the past month or so, wrt to *HCI. There are even patches
> > floating on linux-usb right now trying to hash out the problems.
>
> Ah, glad to see that is happening. I can probably get rid of a bunch
> of randconfig patches I have for those then.
glad to hear you're sorting out randconfig :-)
> > Maybe you should have consulted the maintainers of those drivers before
> > making such statements.
> >
> > MUSB is not the best example because of its history. I understand the
> > DMA part is still really messy, but we have been working very hard to
> > hash the problems and still allow new glue layers to be merged.
>
> Sorry if I have made my statement sound like an accusation, it wasn't
> meant as one, merely as a sigh at having identified yet another area
> that needs to be changed in order to have cross-platform ARM kernels
> working in every case.
no big deal ;-)
> > How about taking a sneak pick at what the code does right now ? As of
> > today, I can even even have all UDC controller drivers into one kernel
> > and I generally compile x86 with all controllers available. There's some
> > very small work that has to be done on each of the UDC drivers to remove
> > any references to <arch/..> <asm/..> and <plat/..> headers but that work
> > in in progress.
>
> I didn't really see any problems with UDC at all. What I saw were a lot
> of build problems with the musb host side, and I rewrote this patch half
> a dozen times before I ended up with a version that consistently built
> without making the code look worse.
I understand.
> I also agree that the musb implementation is less of a problem than
> ohci/ehci in its current form, as it already is layered in the right
> way. I did not attempt to turn the Kconfig 'choice' statement there
> into a flat list though, so I wouldn't know what problems to expect.
Actually, MUSB still has lots of goofage from the original mentor
release but that's another story.
Anyway, I'll take your patches in, but their too late for this merge
window :-( I already sent my last pull to Greg.
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20111003/d84b67a2/attachment.sig>
next prev parent reply other threads:[~2011-10-02 22:10 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-02 14:45 [PATCH 00/30] ARM/omap: omap specific randconfig fixes Arnd Bergmann
2011-10-02 14:45 ` [PATCH 01/30] sound/omap: omap_mcpdm_remove cannot be __devexit Arnd Bergmann
2011-10-02 19:24 ` Mark Brown
2011-10-02 14:45 ` [PATCH 02/30] video/omap: fix dependencies Arnd Bergmann
2011-10-03 6:53 ` Tomi Valkeinen
2011-10-03 9:51 ` Arnd Bergmann
2011-10-02 14:45 ` [PATCH 03/30] video/omap: fix build dependencies Arnd Bergmann
2011-10-03 6:59 ` Tomi Valkeinen
2011-10-03 9:51 ` Arnd Bergmann
2011-10-02 14:45 ` [PATCH 04/30] ARM: omap: add missing __devexit_p() annotations Arnd Bergmann
2011-10-02 15:56 ` Bjarne Steinsbo
2011-10-02 16:09 ` Russell King - ARM Linux
2011-10-03 17:46 ` Tony Lindgren
2011-10-03 17:48 ` Tony Lindgren
2011-10-03 4:59 ` Santosh Shilimkar
2011-10-02 14:45 ` [PATCH 05/30] ARM: omap: enable building omap2 without omap2420/2430 Arnd Bergmann
2011-10-03 5:07 ` Santosh Shilimkar
2011-10-03 17:53 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 06/30] ARM: omap: fix build with CONFIG_I2C_OMAP disabled Arnd Bergmann
2011-10-03 5:06 ` Santosh Shilimkar
2011-10-02 14:45 ` [PATCH 07/30] ARM: omap: fix visibility of omap2_mbox_iva_priv Arnd Bergmann
2011-10-03 5:08 ` Santosh Shilimkar
2011-10-02 14:45 ` [PATCH 08/30] ARM: omap2+: fix building without i2c Arnd Bergmann
2011-10-03 1:31 ` Paul Walmsley
2011-10-03 9:49 ` Arnd Bergmann
2011-10-03 17:56 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 09/30] ARM: omap2: export functions used by nand driver Arnd Bergmann
2011-10-03 17:56 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 10/30] ARM: omap/iommu: always provide iommu debug code Arnd Bergmann
2011-10-02 16:34 ` Ohad Ben-Cohen
2011-10-02 18:01 ` Arnd Bergmann
2011-10-02 18:21 ` Ohad Ben-Cohen
2011-10-03 17:57 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 11/30] ARM: omap2/n8x0: work around modular omap mmc Arnd Bergmann
2011-10-02 15:53 ` Russell King - ARM Linux
2011-10-02 18:54 ` Arnd Bergmann
2011-10-03 18:03 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 12/30] ARM: omap4: always build omap_phy_internal Arnd Bergmann
2011-10-03 18:04 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 13/30] ARM: omap2+: fix omap_hdq_init compilation Arnd Bergmann
2011-10-03 5:11 ` Santosh Shilimkar
2011-10-03 18:06 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 14/30] ARM: omap2: irq.c is always needed Arnd Bergmann
2011-10-03 5:14 ` Santosh Shilimkar
2011-10-02 14:45 ` [PATCH 15/30] usb/musb: use a Kconfig choice to pick the right DMA method Arnd Bergmann
2011-10-02 16:14 ` Russell King - ARM Linux
2011-10-02 18:00 ` Arnd Bergmann
2011-10-02 18:56 ` Felipe Balbi
2011-10-02 19:44 ` Arnd Bergmann
2011-10-02 22:10 ` Felipe Balbi [this message]
2011-10-03 9:40 ` Arnd Bergmann
2011-10-03 10:07 ` Felipe Balbi
2011-10-10 6:10 ` Felipe Balbi
2011-10-02 14:45 ` [PATCH 16/30] usb/musb: HDRC depends on TWL4030_CORE for OMAP3/4 Arnd Bergmann
2011-10-02 18:59 ` Felipe Balbi
2011-10-02 14:45 ` [PATCH 17/30] usb/musb: allow building USB_MUSB_TUSB6010 as a module Arnd Bergmann
2011-10-03 18:14 ` Tony Lindgren
2011-10-10 6:10 ` Felipe Balbi
2011-10-02 14:45 ` [PATCH 18/30] omap-usb: automatically select MFD_OMAP_USB_HOST Arnd Bergmann
2011-10-04 11:00 ` Samuel Ortiz
2011-10-02 14:45 ` [PATCH 19/30] tty/serial/omap: console can only be built-in Arnd Bergmann
2011-10-03 4:53 ` Govindraj
2011-10-02 14:45 ` [PATCH 20/30] media/omap_vout: disable driver for now Arnd Bergmann
2011-10-03 6:09 ` Archit Taneja
2011-10-03 9:16 ` Arnd Bergmann
2011-10-02 14:45 ` [PATCH 21/30] sound/soc/omap: limit to omap2plus Arnd Bergmann
2011-10-02 17:40 ` Jarkko Nikula
2011-10-02 18:03 ` Arnd Bergmann
2011-10-02 18:24 ` Jarkko Nikula
2011-10-02 18:30 ` Arnd Bergmann
2011-10-02 19:18 ` Mark Brown
2011-10-02 14:45 ` [PATCH 22/30] mfd: build twl6030 only on omap2 Arnd Bergmann
2011-10-04 10:47 ` Samuel Ortiz
2011-10-04 14:47 ` Arnd Bergmann
2011-10-02 14:45 ` [PATCH 23/30] ARM: omap2: select twl4030 support on boards that need it Arnd Bergmann
2011-10-03 5:19 ` Santosh Shilimkar
2011-10-03 11:03 ` Arnd Bergmann
2011-10-03 18:18 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 24/30] ARM: omap2+: ensure that one of omap2/3/4 is selected Arnd Bergmann
2011-10-03 5:20 ` Santosh Shilimkar
2011-10-03 18:21 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 25/30] ARM: OMAP depends on MMU Arnd Bergmann
2011-10-03 5:21 ` Santosh Shilimkar
2011-10-03 18:22 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 26/30] ARM: omap: add board autoselection Arnd Bergmann
2011-10-03 5:28 ` Santosh Shilimkar
2011-10-03 9:11 ` Arnd Bergmann
2011-10-03 9:19 ` Santosh Shilimkar
2011-10-03 9:27 ` Cousson, Benoit
2011-10-03 9:54 ` Arnd Bergmann
2011-10-03 18:26 ` Tony Lindgren
2011-10-04 7:44 ` Arnd Bergmann
2011-10-04 15:57 ` Tony Lindgren
2011-10-04 19:29 ` Arnd Bergmann
2011-10-05 1:05 ` [GIT PULL] initial omap DT support for v3.2 merge window (Re: [PATCH 26/30] ARM: omap: add board autoselection) Tony Lindgren
2011-10-14 16:02 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 27/30] ARM: omap: select L2X0 cache on omap4 Arnd Bergmann
2011-10-03 5:29 ` Santosh Shilimkar
2011-10-03 18:27 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 28/30] ARM: omap: select CPU_FREQ_TABLE where needed Arnd Bergmann
2011-10-03 5:39 ` Santosh Shilimkar
2011-10-03 9:15 ` Arnd Bergmann
2011-10-03 9:33 ` Santosh Shilimkar
2011-10-02 14:45 ` [PATCH 29/30] ARM: omap: select USB_ARCH_HAS_EHCI only when USB is enabled Arnd Bergmann
2011-10-03 18:27 ` Tony Lindgren
2011-10-02 14:46 ` [PATCH 30/30] ARM: omap2: select ARM_AMBA for OMAP3_EMU Arnd Bergmann
2011-10-03 5:31 ` Santosh Shilimkar
2011-10-03 18:28 ` Tony Lindgren
2011-10-03 5:05 ` [PATCH 00/30] ARM/omap: omap specific randconfig fixes Santosh Shilimkar
2011-10-03 9:22 ` Arnd Bergmann
2011-10-03 9:42 ` Santosh Shilimkar
2011-10-03 18:29 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111002221050.GA25790@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).