From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] ARM: cache-l2x0: add resume entry for l2 in secure mode
Date: Mon, 3 Oct 2011 14:41:46 +0100 [thread overview]
Message-ID: <20111003134145.GE11710@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20111003105658.GC14761@e102568-lin.cambridge.arm.com>
On Mon, Oct 03, 2011 at 11:57:03AM +0100, Lorenzo Pieralisi wrote:
> On Sat, Oct 01, 2011 at 04:06:46PM +0100, Russell King - ARM Linux wrote:
> > On Fri, Sep 30, 2011 at 02:42:53AM -0700, Barry Song wrote:
> > > From: Barry Song <Baohua.Song@csr.com>
> > >
> > > we save the l2x0 registers at the first initialization, and platform codes
> > > can get them to restore l2x0 status after wakeup.
> > >
> > > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> > > Signed-off-by: Barry Song <Baohua.Song@csr.com>
> > > Reviewed-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> > > Tested-by: Shawn Guo <shawn.guo@linaro.org>
> >
> > This looks fine, thanks Barry.
> >
> > The one remaining issue is whether we use this or use Lorenzo's patches.
> > I feel that Barry's version is a lot simpler and easier to use, so this
> > is my preference. Anyone else got another opinion between the two?
> >
>
> Basically the two patches do the same thing except that Barry's generic
> resume code cannot be called before the MMU is turned on. On the other hand
> Barry's patch is certainly simpler to maintain and I think it should be
> merged, preference shared; I would not say it is easier to use though, usage
> is identical.
>
> It is agreed, better to have it in C than in asm for maintenance reasons,
> asm can turn out overkill.
> If there is a compelling case for generic L2 asm we can always add it at a
> later stage (at least Origen, latest iMX and I think Tegra will need early L2
> resume from idle).
Ok, so it sounds like we're settled on Barry's code... so can it head to
the patch system please?
next prev parent reply other threads:[~2011-10-03 13:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 9:42 [PATCH v4] ARM: cache-l2x0: add resume entry for l2 in secure mode Barry Song
2011-10-01 15:06 ` Russell King - ARM Linux
2011-10-03 10:57 ` Lorenzo Pieralisi
2011-10-03 13:41 ` Russell King - ARM Linux [this message]
2011-10-03 14:18 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111003134145.GE11710@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox