From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: remove bashism in check for multiple zreladdrs
Date: Tue, 4 Oct 2011 09:34:04 +0200 [thread overview]
Message-ID: <20111004073404.GI31404@pengutronix.de> (raw)
In-Reply-To: <1317660736-19081-1-git-send-email-rabin@rab.in>
On Mon, Oct 03, 2011 at 10:22:16PM +0530, Rabin Vincent wrote:
> Get rid of this complaint from dash:
>
> AS arch/arm/boot/compressed/lib1funcs.o
> /bin/sh: 1: [: y: unexpected operator
> LD arch/arm/boot/compressed/vmlinux
>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: Rabin Vincent <rabin@rab.in>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
I guess using '=' for a comparison is hard to type for a C programmer ;)
Sascha
> ---
> arch/arm/boot/compressed/Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed/Makefile
> index a53a333..a6b30b3 100644
> --- a/arch/arm/boot/compressed/Makefile
> +++ b/arch/arm/boot/compressed/Makefile
> @@ -140,7 +140,7 @@ bad_syms=$$($(CROSS_COMPILE)nm $@ | sed -n 's/^.\{8\} [bc] \(.*\)/\1/p') && \
> echo "$$bad_syms" >&2; rm -f $@; false )
>
> check_for_multiple_zreladdr = \
> -if [ $(words $(ZRELADDR)) -gt 1 -a "$(CONFIG_AUTO_ZRELADDR)" == "" ]; then \
> +if [ $(words $(ZRELADDR)) -gt 1 -a "$(CONFIG_AUTO_ZRELADDR)" = "" ]; then \
> echo 'multiple zreladdrs: $(ZRELADDR)'; \
> echo 'This needs CONFIG_AUTO_ZRELADDR to be set'; \
> false; \
> --
> 1.7.5.4
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2011-10-04 7:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 16:52 [PATCH] ARM: remove bashism in check for multiple zreladdrs Rabin Vincent
2011-10-04 7:34 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111004073404.GI31404@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).