From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: SAMSUNG: Add lookup of sdhci-s3c clocks using generic names
Date: Wed, 5 Oct 2011 09:30:30 +0200 [thread overview]
Message-ID: <201110050930.32216.heiko@sntech.de> (raw)
In-Reply-To: <1317792669-19925-4-git-send-email-rajeshwari.s@samsung.com>
Am Mittwoch, 5. Oktober 2011, 07:31:09 schrieb Rajeshwari Shinde:
> Add support for lookup of sdhci-s3c controller clocks using generic names
> for s3c2416, s3c64xx, s5pc100, s5pv210 and exynos4 SoC's.
>
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> ---
[...]
> diff --git a/arch/arm/mach-s3c2416/clock.c b/arch/arm/mach-s3c2416/clock.c
> index 72b7c62..cebaf3f 100644
> --- a/arch/arm/mach-s3c2416/clock.c
> +++ b/arch/arm/mach-s3c2416/clock.c
[...]
> @@ -143,8 +142,14 @@ static struct clksrc_clk *clksrcs[] __initdata = {
> &hsspi_mux,
> &hsmmc_div[0],
> &hsmmc_div[1],
> - &hsmmc_mux[0],
> - &hsmmc_mux[1],
> + &hsmmc_mux0,
> + &hsmmc_mux1,
> +};
> +
> +static struct clk_lookup s3c2416_clk_lookup[] = {
> + CLKDEV_INIT("s3c-sdhci.0", "mmc_busclk.0", &hsmmc0_clk),
This is missing the s3c-sdhci.1 mmc_busclk.0 as 4th entry which is defined in
s3c2443-clock.c. The pclk for hsmmc1 is common to S3C2416/2450 and S3C2443 and
is therefore defined in plat-s3c24xx [S3C2443 only has a hsmmc1 to be exact].
Also it would be nice to include the hsmmc-clock in mach-s3c2443/clock.c too.
The sdhci support there seems to be incomplete but it would be nice to have
the clocks similar to everything else if anyone wants to start on this arch.
> + CLKDEV_INIT("s3c-sdhci.0", "mmc_busclk.2", &hsmmc_mux0.clk),
> + CLKDEV_INIT("s3c-sdhci.1", "mmc_busclk.2", &hsmmc_mux1.clk),
> };
>
> void __init s3c2416_init_clocks(int xtal)
> @@ -164,6 +169,7 @@ void __init s3c2416_init_clocks(int xtal)
> s3c_register_clksrc(clksrcs[ptr], 1);
>
> s3c24xx_register_clock(&hsmmc0_clk);
> + clkdev_add_table(s3c2416_clk_lookup, ARRAY_SIZE(s3c2416_clk_lookup));
>
> s3c_pwmclk_init();
>
Heiko
next prev parent reply other threads:[~2011-10-05 7:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-05 5:31 [PATCH 0/3] ARM: SAMSUNG: Add support for sdhci clock lookup using generic names Rajeshwari Shinde
2011-10-05 5:31 ` [PATCH 1/3] SDHCI: S3C: Use generic clock names for sdhci bus clock options Rajeshwari Shinde
2011-10-05 5:31 ` [PATCH 2/3] ARM: SAMSUNG: Remove SDHCI bus clocks from platform data Rajeshwari Shinde
2011-10-05 5:31 ` [PATCH 3/3] ARM: SAMSUNG: Add lookup of sdhci-s3c clocks using generic names Rajeshwari Shinde
2011-10-05 7:30 ` Heiko Stübner [this message]
2011-10-11 3:39 ` Rajeshwari Birje
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110050930.32216.heiko@sntech.de \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox