[PATCH 1/3 v3] ARM Realview PCIX map include file changes

Arnd Bergmann
2011-10-07T12:26:33Z

On Friday 07 October 2011, Catalin Marinas wrote:
> > However, after changing both __io() and pcibios_min_io as Arnd suggested the boot still hangs after " Uncompressing Linux... done, booting the kernel."
>
> I haven't followed the patch series in detail but the __io() is also
> used by __io_address() in the RealView code and the former is just
> expected to do some type casting. By doing some arithmetic on the
> pointer, the static mappings for various peripherals (GIC etc.) are
> wrong.
>
> So if you convert __io() as per Arnd's suggestion, make sure that
> __io_address() is redefined, something like below:
>
> #define __io_address(n) __typesafe_io(IO_ADDRESS(n))

Ah, right. That definitely explains why it would not boot.

> Alternatively we could leave __io() as in the original kernel and
> define RealView specific in*/out* macros.

I wouldn't recommend that, since that would just have to be reverted
as we get closer to having a single zimage across platforms.
Your suggested fix above should be enough.

Arnd