From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Mon, 10 Oct 2011 14:34:55 +0100 Subject: [PATCH 2/3] ARM: plat-samsung: use Kconfig choice for debug UART selection In-Reply-To: References: <1313530873-24961-1-git-send-email-will.deacon@arm.com> <1313530873-24961-2-git-send-email-will.deacon@arm.com> <20111010122319.GE2451@mudshark.cambridge.arm.com> Message-ID: <20111010133455.GH2451@mudshark.cambridge.arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Oct 10, 2011 at 01:35:54PM +0100, Thomas Abraham wrote: > There are no difficulties with the original patch. But that was not > how Samsung boards have been selecting the low level debug uart port > number. The proposed patch tried to maintain the old style. > > Another point is that Samsung's Exynos4 (and few other SoC's) has a > fourth UART port as well. Not that it is used as a debug port > currently, but there is no technical limitation in using that as a > console port. So that might need 'DEBUG_S3C_UART3' as well. Tell you what then: let's stick with the original patch for now and then you can refactor the Samsung bit in the future if/when you add support for the fourth UART. Does that sound OK? Will