linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: zImage: Use $(CROSS_COMPILE)size to get .bss size
@ 2011-10-12 11:33 Thomas Weber
  2011-10-12 14:37 ` Nicolas Pitre
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Weber @ 2011-10-12 11:33 UTC (permalink / raw)
  To: linux-arm-kernel

Use $(CROSS_COMPILE)size to determine the bss size
from vmlinux.

The problem is introduced in:
commit 8738646c02064d38f6fb056eb039ebf9138c5434

ARM: zImage: make sure appended DTB doesn't get
overwritten by kernel .bss

This fixes following error message:

size: arch/arm/boot/compressed/../../../../vmlinux:
File format is ambiguous

size: Matching formats:
elf32-littlearm
elf32-littlearm-symbian
elf32-littlearm-vxworks

Signed-off-by: Thomas Weber <weber@corscience.de>
---
 arch/arm/boot/compressed/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed/Makefile
index e4f32a8..3103632 100644
--- a/arch/arm/boot/compressed/Makefile
+++ b/arch/arm/boot/compressed/Makefile
@@ -126,7 +126,7 @@ ccflags-y := -fpic -fno-builtin -I$(obj)
 asflags-y := -Wa,-march=all
 
 # Supply kernel BSS size to the decompressor via a linker symbol.
-KBSS_SZ = $(shell size $(obj)/../../../../vmlinux | awk 'END{print $$3}')
+KBSS_SZ = $(shell $(CROSS_COMPILE)size $(obj)/../../../../vmlinux | awk 'END{print $$3}')
 LDFLAGS_vmlinux = --defsym _kernel_bss_size=$(KBSS_SZ)
 # Supply ZRELADDR to the decompressor via a linker symbol.
 ifneq ($(CONFIG_AUTO_ZRELADDR),y)
-- 
1.7.7

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] ARM: zImage: Use $(CROSS_COMPILE)size to get .bss size
  2011-10-12 11:33 [PATCH] ARM: zImage: Use $(CROSS_COMPILE)size to get .bss size Thomas Weber
@ 2011-10-12 14:37 ` Nicolas Pitre
  2011-10-12 21:10   ` Tony Lindgren
  0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Pitre @ 2011-10-12 14:37 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, 12 Oct 2011, Thomas Weber wrote:

> Use $(CROSS_COMPILE)size to determine the bss size
> from vmlinux.
> 
> The problem is introduced in:
> commit 8738646c02064d38f6fb056eb039ebf9138c5434
> 
> ARM: zImage: make sure appended DTB doesn't get
> overwritten by kernel .bss
> 
> This fixes following error message:
> 
> size: arch/arm/boot/compressed/../../../../vmlinux:
> File format is ambiguous
> 
> size: Matching formats:
> elf32-littlearm
> elf32-littlearm-symbian
> elf32-littlearm-vxworks
> 
> Signed-off-by: Thomas Weber <weber@corscience.de>

Acked-by: Nicolas Pitre <nicolas.pitre@linaro.org>

However I don't know where you picked up a reference to commit 
8738646c02 which is nonexistent in any of my repositories.  The right 
reference from RMK's devel-stable branch would be commit 5ffb04f669.  
Please fix that and send to the patch system.


Nicolas

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] ARM: zImage: Use $(CROSS_COMPILE)size to get .bss size
  2011-10-12 14:37 ` Nicolas Pitre
@ 2011-10-12 21:10   ` Tony Lindgren
  0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2011-10-12 21:10 UTC (permalink / raw)
  To: linux-arm-kernel

* Nicolas Pitre <nicolas.pitre@linaro.org> [111012 07:03]:
> On Wed, 12 Oct 2011, Thomas Weber wrote:
> 
> > Use $(CROSS_COMPILE)size to determine the bss size
> > from vmlinux.
> > 
> > The problem is introduced in:
> > commit 8738646c02064d38f6fb056eb039ebf9138c5434
> > 
> > ARM: zImage: make sure appended DTB doesn't get
> > overwritten by kernel .bss
> > 
> > This fixes following error message:
> > 
> > size: arch/arm/boot/compressed/../../../../vmlinux:
> > File format is ambiguous
> > 
> > size: Matching formats:
> > elf32-littlearm
> > elf32-littlearm-symbian
> > elf32-littlearm-vxworks
> > 
> > Signed-off-by: Thomas Weber <weber@corscience.de>
> 
> Acked-by: Nicolas Pitre <nicolas.pitre@linaro.org>

Acked-by: Tony Lindgren <tony@atomide.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-10-12 21:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-12 11:33 [PATCH] ARM: zImage: Use $(CROSS_COMPILE)size to get .bss size Thomas Weber
2011-10-12 14:37 ` Nicolas Pitre
2011-10-12 21:10   ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).