From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm/tegra: pinmux: ioremap registers
Date: Wed, 12 Oct 2011 15:42:36 -0700 [thread overview]
Message-ID: <20111012224236.GE25128@quad.lixom.net> (raw)
In-Reply-To: <1318434867-19120-1-git-send-email-swarren@nvidia.com>
On Wed, Oct 12, 2011 at 09:54:27AM -0600, Stephen Warren wrote:
> Use ioremap to obtain access to registers instead of using static
> mappings. This reduces the number of users of the static mappings, which
> will eventually allow them to be removed.
>
> Note that on Tegra30, the number of register "banks" will decrease to 2,
> and the packing of specific bits into registers will change significantly.
> That's why this change adds the "*_bank" fields to the pingroup tables,
> rather than implementing some more hard-coded scheme.
>
> Also, completely remove the implementation of suspend/resume; Tegra doesn't
> yet support suspend/resume, and the implementation is complex for the
> general pinmux driver:
>
> * Not all registers are used within each bank, so we probably shouldn't
> just iterate over every register in the bank, and save/restore it,
> since that would mean touching undefined registers.
>
> * Registers are shared between pingroups, so we can't simply iterate over
> each pingroup, and save/restore the registers it uses.
>
> It'd probably be best have probe() calculate a bitmask of actually-used
> registers for each bank, and have suspend/resume iterate over those
> bitmaps.
>
> Oh, and Real Soon Now, I should be looking into converting this driver to
> the new pinmux/pinctrl subsystem, so I didn't want to put too much work
> into the current incarnation.
>
> v2: s/space/bank/ to match comments on reg_* fields in pinmux.h.
> Re-order bank/reg parameters to pg_readl/pg_writel.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
Thanks, applied to for-3.2/features.
-Olof
prev parent reply other threads:[~2011-10-12 22:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 15:54 [PATCH v2] arm/tegra: pinmux: ioremap registers Stephen Warren
2011-10-12 22:42 ` Olof Johansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111012224236.GE25128@quad.lixom.net \
--to=olof@lixom.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).