From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 1/2] ARM: EXYNOS4: Add SPI support
Date: Thu, 13 Oct 2011 11:02:06 +0100 [thread overview]
Message-ID: <20111013100206.GP21648@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1318234084-19960-2-git-send-email-padma.v@samsung.com>
On Mon, Oct 10, 2011 at 01:38:04PM +0530, Padmavathi Venna wrote:
> +void __init exynos4_spi_set_info(int cntrlr, int src_clk_nr, int num_cs)
> +{
> + struct s3c64xx_spi_info *pd;
> +
> + /* Reject invalid configuration */
> + if (!num_cs || src_clk_nr < 0
> + || src_clk_nr > EXYNOS4_SPI_SRCCLK_SCLK) {
> + printk(KERN_ERR "%s: Invalid SPI configuration\n", __func__);
Let's start using pr_err() rather than printk(KERN_ERR...) in ARM code
please.
prev parent reply other threads:[~2011-10-13 10:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 8:08 [PATCH V2 0/2]: Add SPI Support on Exynos4 Padmavathi Venna
2011-10-10 8:08 ` [PATCH V2 1/2] ARM: EXYNOS4: Add SPI support Padmavathi Venna
2011-10-10 9:33 ` Kukjin Kim
2011-10-24 15:24 ` Kukjin Kim
2011-10-13 10:02 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111013100206.GP21648@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).