linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] mmc: mmci: Bugfix in pio read for small packets
Date: Thu, 13 Oct 2011 16:48:03 +0100	[thread overview]
Message-ID: <20111013154803.GH21648@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <4E92AB66.1030406@stericsson.com>

On Mon, Oct 10, 2011 at 10:23:02AM +0200, Ulf Hansson wrote:
> Linus Walleij wrote:
>> On Sat, Oct 8, 2011 at 11:10 AM, Russell King - ARM Linux
>> <linux@arm.linux.org.uk> wrote:
>>> On Fri, Oct 07, 2011 at 03:45:48PM +0200, Ulf Hansson wrote:
>>>
>>> Well, the patch system says that each one depends on the previous one,
>>> and the first one in the series contains the PIO read thing.
>>>
>>> Do 7108/1 onwards depend on 7106/1 and 7107/1 ?
>>
>> Probably my fault, since I was helping Ulf out with the patch tracker
>> introduction.
>>
>> The patches should be pretty much semantically orthogonal as
>> far as I can tell, the only reason dependency was stated that way
>> was that I couldn't tell from head-parsing whether there were
>> syntactical dependencies. (And wanted to avoid the annoyance
>> of non-applying patches...)
>>
>> So if they apply, they are independent AFAICT.
>
> 7108/1 and 7109/1, have real dependencies. Otherwise there none.

Ok, I assume that those depend on the first two patches.

So, I tried applying 7110/1 .. 7112/1 but the first rejects because it
doesn't have the non-power-of-2 support patch applied (7107/1).  And
it seems sensible that 7107/1 depends on 7106/1 (the PIO patch) which
I believe to be a problem.

Therefore, I don't think any of these can be applied without the
initial PIO patch.

One thing I haven't yet mentioned is about the non-power-of-2 support -
surely this can only be supported if blksz_datactrl16 is set?  If so,
shouldn't it key off that?  I don't see how it could otherwise support
non-power of 2 block sizes with just a log2 of the block size programmed
into the data control register.

  reply	other threads:[~2011-10-13 15:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-27  7:46 [PATCH 1/4] mmc: mmci: Bugfix in pio read for small packets Ulf Hansson
2011-10-01 16:09 ` Russell King - ARM Linux
2011-10-03  7:08   ` Stefan Nilsson XK
2011-10-07 13:38     ` Ulf Hansson
2011-10-07 19:11       ` Russell King - ARM Linux
2011-10-14  7:38         ` Stefan Nilsson XK
2011-10-07 13:45   ` Ulf Hansson
2011-10-08  9:10     ` Russell King - ARM Linux
2011-10-09  6:59       ` Linus Walleij
2011-10-10  8:23         ` Ulf Hansson
2011-10-13 15:48           ` Russell King - ARM Linux [this message]
2011-10-14  8:07             ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111013154803.GH21648@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).