[PATCH] AT91: Add external RTC for Flexibity board

[PATCH] AT91: Add external RTC for Flexibity board

[Maxim Osipov]

Hello,

This patch enables external RTC support on AT91 Flexibity board.

Kind regards,
Maxim


Signed-off-by: Maxim Osipov <maxim.osipov@gmail.com>
---
 arch/arm/mach-at91/board-flexibity.c |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-at91/board-flexibity.c b/arch/arm/mach-at91/board-flexibity.c
index c8a62dc..4fdc96c 100644
--- a/arch/arm/mach-at91/board-flexibity.c
+++ b/arch/arm/mach-at91/board-flexibity.c
@@ -1,7 +1,7 @@
 /*
  * linux/arch/arm/mach-at91/board-flexibity.c
  *
- *  Copyright (C) 2010 Flexibity
+ *  Copyright (C) 2010-2011 Flexibity
  *  Copyright (C) 2005 SAN People
  *  Copyright (C) 2006 Atmel
  *
@@ -65,6 +65,13 @@ static struct at91_udc_data __initdata flexibity_udc_data = {
 	.pullup_pin	= 0,		/* pull-up driven by UDC */
 };
 
+/* I2C devices */
+static struct i2c_board_info __initdata flexibity_i2c_devices[] = {
+	{
+		I2C_BOARD_INFO("ds1307", 0x68),
+	},
+};
+
 /* SPI devices */
 static struct spi_board_info flexibity_spi_devices[] = {
 	{	/* DataFlash chip */
@@ -143,6 +150,9 @@ static void __init flexibity_board_init(void)
 	at91_add_device_usbh(&flexibity_usbh_data);
 	/* USB Device */
 	at91_add_device_udc(&flexibity_udc_data);
+	/* I2C */
+	at91_add_device_i2c(flexibity_i2c_devices,
+		ARRAY_SIZE(flexibity_i2c_devices));
 	/* SPI */
 	at91_add_device_spi(flexibity_spi_devices,
 		ARRAY_SIZE(flexibity_spi_devices));
-- 
1.7.4.1

[PATCH] AT91: Add external RTC for Flexibity board

[Maxim Osipov]

Hi,

On Sat, May 7, 2011 at 12:47 PM, Maxim Osipov <maxim.osipov@gmail.com> wrote:
>
> This patch enables external RTC support on AT91 Flexibity board.
>
> Signed-off-by: Maxim Osipov <maxim.osipov@gmail.com>
> ---
> ?arch/arm/mach-at91/board-flexibity.c | ? 12 +++++++++++-
> ?1 files changed, 11 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-at91/board-flexibity.c b/arch/arm/mach-at91/board-flexibity.c
> index c8a62dc..4fdc96c 100644
> --- a/arch/arm/mach-at91/board-flexibity.c
> +++ b/arch/arm/mach-at91/board-flexibity.c
> @@ -1,7 +1,7 @@
> ?/*
> ?* linux/arch/arm/mach-at91/board-flexibity.c
> ?*
> - * ?Copyright (C) 2010 Flexibity
> + * ?Copyright (C) 2010-2011 Flexibity
> ?* ?Copyright (C) 2005 SAN People
> ?* ?Copyright (C) 2006 Atmel
> ?*
> @@ -65,6 +65,13 @@ static struct at91_udc_data __initdata flexibity_udc_data = {
> ? ? ? ?.pullup_pin ? ? = 0, ? ? ? ? ? ?/* pull-up driven by UDC */
> ?};
>
> +/* I2C devices */
> +static struct i2c_board_info __initdata flexibity_i2c_devices[] = {
> + ? ? ? {
> + ? ? ? ? ? ? ? I2C_BOARD_INFO("ds1307", 0x68),
> + ? ? ? },
> +};
> +
> ?/* SPI devices */
> ?static struct spi_board_info flexibity_spi_devices[] = {
> ? ? ? ?{ ? ? ? /* DataFlash chip */
> @@ -143,6 +150,9 @@ static void __init flexibity_board_init(void)
> ? ? ? ?at91_add_device_usbh(&flexibity_usbh_data);
> ? ? ? ?/* USB Device */
> ? ? ? ?at91_add_device_udc(&flexibity_udc_data);
> + ? ? ? /* I2C */
> + ? ? ? at91_add_device_i2c(flexibity_i2c_devices,
> + ? ? ? ? ? ? ? ARRAY_SIZE(flexibity_i2c_devices));
> ? ? ? ?/* SPI */
> ? ? ? ?at91_add_device_spi(flexibity_spi_devices,
> ? ? ? ? ? ? ? ?ARRAY_SIZE(flexibity_spi_devices));
> --
> 1.7.4.1
>
>

If no comments on the patch - could someone commit it please? Or
should I submit it to the Russell's patch tracking system?

Kind regards,
Maxim

[PATCH] AT91: Add external RTC for Flexibity board

[Jean-Christophe PLAGNIOL-VILLARD]

On 12:47 Sat 07 May     , Maxim Osipov wrote:
> Hello,
> 
> This patch enables external RTC support on AT91 Flexibity board.
> 
> Kind regards,
> Maxim
> 
> 
> Signed-off-by: Maxim Osipov <maxim.osipov@gmail.com>
> ---
>  arch/arm/mach-at91/board-flexibity.c |   12 +++++++++++-
>  1 files changed, 11 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-at91/board-flexibity.c b/arch/arm/mach-at91/board-flexibity.c
> index c8a62dc..4fdc96c 100644
> --- a/arch/arm/mach-at91/board-flexibity.c
> +++ b/arch/arm/mach-at91/board-flexibity.c
> @@ -1,7 +1,7 @@
>  /*
>   * linux/arch/arm/mach-at91/board-flexibity.c
>   *
> - *  Copyright (C) 2010 Flexibity
> + *  Copyright (C) 2010-2011 Flexibity
>   *  Copyright (C) 2005 SAN People
>   *  Copyright (C) 2006 Atmel
>   *
> @@ -65,6 +65,13 @@ static struct at91_udc_data __initdata flexibity_udc_data = {
>  	.pullup_pin	= 0,		/* pull-up driven by UDC */
>  };
>  
> +/* I2C devices */
> +static struct i2c_board_info __initdata flexibity_i2c_devices[] = {
> +	{
> +		I2C_BOARD_INFO("ds1307", 0x68),
> +	},
> +};
> +
looks fine just one comment please add your board to the new at91sam9260_defconfig

so we can compile it when compiling all the sam9260

Best Regards,
J.

[PATCH] AT91: Add external RTC for Flexibity board

[Andrew Victor]

hi,

>> This patch enables external RTC support on AT91 Flexibity board.

Acked-by: Andrew Victor <linux@maxim.org.za>

Maxim: You can submit it to Russell's patch system.


> looks fine just one comment please add your board to the new at91sam9260_defconfig

That file does not exist in any mainline kernel.


Regards,
  Andrew Victor

[PATCH] AT91: Add external RTC for Flexibity board

[Nicolas Ferre]

Le 11/05/2011 09:44, Andrew Victor :
> hi,
> 
>>> This patch enables external RTC support on AT91 Flexibity board.
> 
> Acked-by: Andrew Victor <linux@maxim.org.za>
> 
> Maxim: You can submit it to Russell's patch system. 
> 
>> looks fine just one comment please add your board to the new at91sam9260_defconfig
> 
> That file does not exist in any mainline kernel.

Absolutely, we will come back on this when this common defconfig will be
properly included in mainline.

Bye,
-- 
Nicolas Ferre

[PATCH] AT91: Add external RTC for Flexibity board

[Russell King - ARM Linux]

On Wed, May 11, 2011 at 09:44:52AM +0200, Andrew Victor wrote:
> hi,
> 
> >> This patch enables external RTC support on AT91 Flexibity board.
> 
> Acked-by: Andrew Victor <linux@maxim.org.za>
> 
> Maxim: You can submit it to Russell's patch system.
> 
> 
> > looks fine just one comment please add your board to the new at91sam9260_defconfig
> 
> That file does not exist in any mainline kernel.

It's been a while since this patch went into the patch system, and it
didn't get applied for various reasons, including because it looked
like it was sent there without any review (no acked-by's etc added to
it.)

What's the status of this - and if its still relevant can we have
it with the proper attributations please?

[PATCH] AT91: Add external RTC for Flexibity board

[Maxim Osipov]

Ok, I'll do it. Thanks!
Maxim

On Thu, Oct 13, 2011 at 10:11 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Wed, May 11, 2011 at 09:44:52AM +0200, Andrew Victor wrote:
>> hi,
>>
>> >> This patch enables external RTC support on AT91 Flexibity board.
>>
>> Acked-by: Andrew Victor <linux@maxim.org.za>
>>
>> Maxim: You can submit it to Russell's patch system.
>>
>>
>> > looks fine just one comment please add your board to the new at91sam9260_defconfig
>>
>> That file does not exist in any mainline kernel.
>
> It's been a while since this patch went into the patch system, and it
> didn't get applied for various reasons, including because it looked
> like it was sent there without any review (no acked-by's etc added to
> it.)
>
> What's the status of this - and if its still relevant can we have
> it with the proper attributations please?
>

[PATCH] AT91: Add external RTC for Flexibity board

[Jean-Christophe PLAGNIOL-VILLARD]

On 22:11 Thu 13 Oct     , Russell King - ARM Linux wrote:
> On Wed, May 11, 2011 at 09:44:52AM +0200, Andrew Victor wrote:
> > hi,
> > 
> > >> This patch enables external RTC support on AT91 Flexibity board.
> > 
> > Acked-by: Andrew Victor <linux@maxim.org.za>
> > 
> > Maxim: You can submit it to Russell's patch system.
> > 
> > 
> > > looks fine just one comment please add your board to the new at91sam9260_defconfig
> > 
> > That file does not exist in any mainline kernel.
> 
> It's been a while since this patch went into the patch system, and it
> didn't get applied for various reasons, including because it looked
> like it was sent there without any review (no acked-by's etc added to
> it.)
> 
> What's the status of this - and if its still relevant can we have
> it with the proper attributations please
This patch is already in Arnd tree IIRC

Best Regards,
J.