* [PATCH] ARM: SAMSUNG: s3c-dma-ops needs export.h for EXPORT_SYMBOL
@ 2011-10-07 4:20 Axel Lin
2011-10-11 11:31 ` Kukjin Kim
2011-10-12 12:42 ` Kukjin Kim
0 siblings, 2 replies; 5+ messages in thread
From: Axel Lin @ 2011-10-07 4:20 UTC (permalink / raw)
To: linux-arm-kernel
Fix below build warning:
CC arch/arm/plat-samsung/s3c-dma-ops.o
arch/arm/plat-samsung/s3c-dma-ops.c:130: warning: data definition has no type or storage class
arch/arm/plat-samsung/s3c-dma-ops.c:130: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
arch/arm/plat-samsung/s3c-dma-ops.c:130: warning: parameter names (without types) in function declaration
And fix the build error:
ERROR: "s3c_dma_get_ops" [drivers/spi/spi-s3c64xx.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
This can be reproduced by "make s3c6400_defconfig;make" on linux-next 20111006.
arch/arm/plat-samsung/s3c-dma-ops.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-samsung/s3c-dma-ops.c b/arch/arm/plat-samsung/s3c-dma-ops.c
index 582333c..7814949 100644
--- a/arch/arm/plat-samsung/s3c-dma-ops.c
+++ b/arch/arm/plat-samsung/s3c-dma-ops.c
@@ -14,6 +14,7 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/types.h>
+#include <linux/export.h>
#include <mach/dma.h>
--
1.7.4.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] ARM: SAMSUNG: s3c-dma-ops needs export.h for EXPORT_SYMBOL
2011-10-07 4:20 [PATCH] ARM: SAMSUNG: s3c-dma-ops needs export.h for EXPORT_SYMBOL Axel Lin
@ 2011-10-11 11:31 ` Kukjin Kim
2011-10-12 12:42 ` Kukjin Kim
1 sibling, 0 replies; 5+ messages in thread
From: Kukjin Kim @ 2011-10-11 11:31 UTC (permalink / raw)
To: linux-arm-kernel
Axel Lin wrote:
>
> Fix below build warning:
> CC arch/arm/plat-samsung/s3c-dma-ops.o
> arch/arm/plat-samsung/s3c-dma-ops.c:130: warning: data definition has no type or
> storage class
> arch/arm/plat-samsung/s3c-dma-ops.c:130: warning: type defaults to 'int' in
> declaration of 'EXPORT_SYMBOL'
> arch/arm/plat-samsung/s3c-dma-ops.c:130: warning: parameter names (without
> types) in function declaration
>
> And fix the build error:
> ERROR: "s3c_dma_get_ops" [drivers/spi/spi-s3c64xx.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> This can be reproduced by "make s3c6400_defconfig;make" on linux-next
> 20111006.
> arch/arm/plat-samsung/s3c-dma-ops.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/s3c-dma-ops.c b/arch/arm/plat-samsung/s3c-
> dma-ops.c
> index 582333c..7814949 100644
> --- a/arch/arm/plat-samsung/s3c-dma-ops.c
> +++ b/arch/arm/plat-samsung/s3c-dma-ops.c
> @@ -14,6 +14,7 @@
> #include <linux/errno.h>
> #include <linux/slab.h>
> #include <linux/types.h>
> +#include <linux/export.h>
>
> #include <mach/dma.h>
>
> --
> 1.7.4.1
>
OK, will apply.
BTW, I don't know why the build error/warning was not happened in my tree with s3c6400_defconfig. Probably other file having it?...
Anyway, thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: SAMSUNG: s3c-dma-ops needs export.h for EXPORT_SYMBOL
2011-10-07 4:20 [PATCH] ARM: SAMSUNG: s3c-dma-ops needs export.h for EXPORT_SYMBOL Axel Lin
2011-10-11 11:31 ` Kukjin Kim
@ 2011-10-12 12:42 ` Kukjin Kim
2011-10-12 13:49 ` Axel Lin
1 sibling, 1 reply; 5+ messages in thread
From: Kukjin Kim @ 2011-10-12 12:42 UTC (permalink / raw)
To: linux-arm-kernel
Kukjin Kim wrote:
>
> Axel Lin wrote:
> >
> > Fix below build warning:
> > CC arch/arm/plat-samsung/s3c-dma-ops.o
> > arch/arm/plat-samsung/s3c-dma-ops.c:130: warning: data definition has no type
> or
> > storage class
> > arch/arm/plat-samsung/s3c-dma-ops.c:130: warning: type defaults to 'int' in
> > declaration of 'EXPORT_SYMBOL'
> > arch/arm/plat-samsung/s3c-dma-ops.c:130: warning: parameter names (without
> > types) in function declaration
> >
> > And fix the build error:
> > ERROR: "s3c_dma_get_ops" [drivers/spi/spi-s3c64xx.ko] undefined!
> > make[1]: *** [__modpost] Error 1
> > make: *** [modules] Error 2
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
> > ---
> > This can be reproduced by "make s3c6400_defconfig;make" on linux-next
> > 20111006.
> > arch/arm/plat-samsung/s3c-dma-ops.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/plat-samsung/s3c-dma-ops.c b/arch/arm/plat-samsung/s3c-
> > dma-ops.c
> > index 582333c..7814949 100644
> > --- a/arch/arm/plat-samsung/s3c-dma-ops.c
> > +++ b/arch/arm/plat-samsung/s3c-dma-ops.c
> > @@ -14,6 +14,7 @@
> > #include <linux/errno.h>
> > #include <linux/slab.h>
> > #include <linux/types.h>
> > +#include <linux/export.h>
> >
> > #include <mach/dma.h>
> >
> > --
> > 1.7.4.1
> >
> OK, will apply.
>
> BTW, I don't know why the build error/warning was not happened in my tree with
> s3c6400_defconfig. Probably other file having it?...
>
Hi Axel,
When I applied this in my tree, happened following error with s3c6400_defconfig.
arch/arm/plat-samsung/s3c-dma-ops.c:17: fatal error: linux/export.h: No such file or directory
Probably the <linux/export.h> file has been added from other tree.
So if required, will fix with this during upcoming merge window maybe at end of.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: SAMSUNG: s3c-dma-ops needs export.h for EXPORT_SYMBOL
2011-10-12 12:42 ` Kukjin Kim
@ 2011-10-12 13:49 ` Axel Lin
2011-10-14 3:15 ` Paul Gortmaker
0 siblings, 1 reply; 5+ messages in thread
From: Axel Lin @ 2011-10-12 13:49 UTC (permalink / raw)
To: linux-arm-kernel
2011/10/12 Kukjin Kim <kgene.kim@samsung.com>:
> Kukjin Kim wrote:
>>
>> Axel Lin wrote:
>> >
>> > Fix below build warning:
>> > ? CC ? ? ?arch/arm/plat-samsung/s3c-dma-ops.o
>> > arch/arm/plat-samsung/s3c-dma-ops.c:130: warning: data definition has no type
>> or
>> > storage class
>> > arch/arm/plat-samsung/s3c-dma-ops.c:130: warning: type defaults to 'int' in
>> > declaration of 'EXPORT_SYMBOL'
>> > arch/arm/plat-samsung/s3c-dma-ops.c:130: warning: parameter names (without
>> > types) in function declaration
>> >
>> > And fix the build error:
>> > ERROR: "s3c_dma_get_ops" [drivers/spi/spi-s3c64xx.ko] undefined!
>> > make[1]: *** [__modpost] Error 1
>> > make: *** [modules] Error 2
>> >
>> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
>> > ---
>> > This can be reproduced by "make s3c6400_defconfig;make" on linux-next
>> > 20111006.
>> > ?arch/arm/plat-samsung/s3c-dma-ops.c | ? ?1 +
>> > ?1 files changed, 1 insertions(+), 0 deletions(-)
>> >
>> > diff --git a/arch/arm/plat-samsung/s3c-dma-ops.c b/arch/arm/plat-samsung/s3c-
>> > dma-ops.c
>> > index 582333c..7814949 100644
>> > --- a/arch/arm/plat-samsung/s3c-dma-ops.c
>> > +++ b/arch/arm/plat-samsung/s3c-dma-ops.c
>> > @@ -14,6 +14,7 @@
>> > ?#include <linux/errno.h>
>> > ?#include <linux/slab.h>
>> > ?#include <linux/types.h>
>> > +#include <linux/export.h>
>> >
>> > ?#include <mach/dma.h>
>> >
>> > --
>> > 1.7.4.1
>> >
>> OK, will apply.
>>
>> BTW, I don't know why the build error/warning was not happened in my tree with
>> s3c6400_defconfig. Probably other file having it?...
>>
> Hi Axel,
>
> When I applied this in my tree, happened following error with s3c6400_defconfig.
>
> arch/arm/plat-samsung/s3c-dma-ops.c:17: fatal error: linux/export.h: No such file or directory
>
> Probably the <linux/export.h> file has been added from other tree.
> So if required, will fix with this during upcoming merge window maybe at end of.
>
Cc Paul Gortmaker,
Maybe it is only in Paul's tree now.
Regards,
Axel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: SAMSUNG: s3c-dma-ops needs export.h for EXPORT_SYMBOL
2011-10-12 13:49 ` Axel Lin
@ 2011-10-14 3:15 ` Paul Gortmaker
0 siblings, 0 replies; 5+ messages in thread
From: Paul Gortmaker @ 2011-10-14 3:15 UTC (permalink / raw)
To: linux-arm-kernel
[Re: [PATCH] ARM: SAMSUNG: s3c-dma-ops needs export.h for EXPORT_SYMBOL] On 12/10/2011 (Wed 21:49) Axel Lin wrote:
> 2011/10/12 Kukjin Kim <kgene.kim@samsung.com>:
> > Kukjin Kim wrote:
> >>
> >> Axel Lin wrote:
> >> >
> >> > Fix below build warning:
> >> > ? CC ? ? ?arch/arm/plat-samsung/s3c-dma-ops.o
> >> > arch/arm/plat-samsung/s3c-dma-ops.c:130: warning: data definition has no type
> >> or
> >> > storage class
> >> > arch/arm/plat-samsung/s3c-dma-ops.c:130: warning: type defaults to 'int' in
> >> > declaration of 'EXPORT_SYMBOL'
> >> > arch/arm/plat-samsung/s3c-dma-ops.c:130: warning: parameter names (without
> >> > types) in function declaration
> >> >
> >> > And fix the build error:
> >> > ERROR: "s3c_dma_get_ops" [drivers/spi/spi-s3c64xx.ko] undefined!
> >> > make[1]: *** [__modpost] Error 1
> >> > make: *** [modules] Error 2
> >> >
> >> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
> >> > ---
> >> > This can be reproduced by "make s3c6400_defconfig;make" on linux-next
> >> > 20111006.
> >> > ?arch/arm/plat-samsung/s3c-dma-ops.c | ? ?1 +
> >> > ?1 files changed, 1 insertions(+), 0 deletions(-)
> >> >
> >> > diff --git a/arch/arm/plat-samsung/s3c-dma-ops.c b/arch/arm/plat-samsung/s3c-
> >> > dma-ops.c
> >> > index 582333c..7814949 100644
> >> > --- a/arch/arm/plat-samsung/s3c-dma-ops.c
> >> > +++ b/arch/arm/plat-samsung/s3c-dma-ops.c
> >> > @@ -14,6 +14,7 @@
> >> > ?#include <linux/errno.h>
> >> > ?#include <linux/slab.h>
> >> > ?#include <linux/types.h>
> >> > +#include <linux/export.h>
> >> >
> >> > ?#include <mach/dma.h>
> >> >
> >> > --
> >> > 1.7.4.1
> >> >
> >> OK, will apply.
> >>
> >> BTW, I don't know why the build error/warning was not happened in my tree with
> >> s3c6400_defconfig. Probably other file having it?...
> >>
> > Hi Axel,
> >
> > When I applied this in my tree, happened following error with s3c6400_defconfig.
> >
> > arch/arm/plat-samsung/s3c-dma-ops.c:17: fatal error: linux/export.h: No such file or directory
> >
> > Probably the <linux/export.h> file has been added from other tree.
> > So if required, will fix with this during upcoming merge window maybe at end of.
> >
> Cc Paul Gortmaker,
> Maybe it is only in Paul's tree now.
Correct. The export.h is only in linux-next, which it gets from the
module.h splitup tree. I am currently tracking post-merge export.h
additions to both s3c-dma-ops and also plat-samsung/dma-ops.c files.
THanks,
Paul.
>
> Regards,
> Axel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-10-14 3:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-07 4:20 [PATCH] ARM: SAMSUNG: s3c-dma-ops needs export.h for EXPORT_SYMBOL Axel Lin
2011-10-11 11:31 ` Kukjin Kim
2011-10-12 12:42 ` Kukjin Kim
2011-10-12 13:49 ` Axel Lin
2011-10-14 3:15 ` Paul Gortmaker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).