Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] spi/pl022: disable the PL022 block when unused
Date: Tue, 18 Oct 2011 10:34:31 +0100	[thread overview]
Message-ID: <20111018093431.GK21648@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <4E9D4337.3030700@st.com>

On Tue, Oct 18, 2011 at 02:43:27PM +0530, Viresh Kumar wrote:
> On 10/17/2011 6:42 PM, Linus WALLEIJ wrote:
> > From: Virupax Sadashivpetimath <virupax.sadashivpetimath@stericsson.com>
> > 
> > Make sure we clear the enable bit when the block is not used.
> > This will save some energy in certain hardware versions.
> > 
> > Signed-off-by: Virupax Sadashivpetimath <virupax.sadashivpetimath@stericsson.com>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> >  drivers/spi/spi-pl022.c |    7 ++++++-
> >  1 files changed, 6 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
> > index 91700bb..0a1d8ed 100644
> > --- a/drivers/spi/spi-pl022.c
> > +++ b/drivers/spi/spi-pl022.c
> > @@ -513,7 +513,12 @@ static void giveback(struct pl022 *pl022)
> >  	msg->state = NULL;
> >  	if (msg->complete)
> >  		msg->complete(msg->context);
> > -	/* This message is completed, so let's turn off the clocks & power */
> > +
> > +	/* disable the SPI/SSP operation */
> > +	writew((readw(SSP_CR1(pl022->virtbase)) &
> > +		(~SSP_CR1_MASK_SSE)), SSP_CR1(pl022->virtbase));
> > +
> > +	/* This message is completed, so let's turn off the clock! */
> >  	clk_disable(pl022->clk);
> >  	amba_pclk_disable(pl022->adev);
> >  	amba_vcore_disable(pl022->adev);
> 
> Reviewed-by: Viresh Kumar <viresh.kumar@st.com>

Note that I have some changes around here in my amba branch (which are
dependent on other changes I have for the primecell runtime pm.)

      reply	other threads:[~2011-10-18  9:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-17 13:12 [PATCH 2/3] spi/pl022: disable the PL022 block when unused Linus Walleij
2011-10-18  9:13 ` Viresh Kumar
2011-10-18  9:34   ` Russell King - ARM Linux [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111018093431.GK21648@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox