From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm/imx: add missing include of asm/exception.h for avic.c
Date: Fri, 21 Oct 2011 20:07:17 +0200 [thread overview]
Message-ID: <20111021180717.GJ23421@pengutronix.de> (raw)
In-Reply-To: <8805141.r6GF1WOsYI@wuerfel>
On Fri, Oct 21, 2011 at 06:38:32PM +0200, Arnd Bergmann wrote:
> On Friday 21 October 2011 09:22:19 Uwe Kleine-K?nig wrote:
> >
> > On Fri, Oct 21, 2011 at 10:33:00AM +0800, Shawn Guo wrote:
> > > It adds missing include of asm/exception.h for avic.c to fix the
> > > compile error below.
> > >
> > > arch/arm/plat-mxc/avic.c:154:39: error: expected ?=?, ?,?, ?;?,
> > > ?asm? or ?__attribute__? before ?avic_handle_irq?
> > >
> > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> > Arnd already posted a patch for that[1], but this one looks better.
> >
> > Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
>
> Ok, thanks!
>
> I found the same problem in plat-mxc/tzic.c as well now.
>
> Which branch should we apply the patch to? The header file was
> introduced in rmk's smp branch, but the usage was introduced in
> the imx/multi-irq branch.
>
> Should I merge the smp branch into imx/multi-irq and fix up the
> breakage in the merge commit?
Ok, this one is already found. Putting it into the merge commit sounds
good.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2011-10-21 18:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-21 2:33 [PATCH] arm/imx: add missing include of asm/exception.h for avic.c Shawn Guo
2011-10-21 7:22 ` Uwe Kleine-König
2011-10-21 16:38 ` Arnd Bergmann
2011-10-21 18:07 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111021180717.GJ23421@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).