* [PATCH] dt: Add empty of_match_node() macro
@ 2011-10-24 9:53 Nicolas Ferre
2011-10-24 10:06 ` Grant Likely
2011-10-24 14:25 ` Grant Likely
0 siblings, 2 replies; 3+ messages in thread
From: Nicolas Ferre @ 2011-10-24 9:53 UTC (permalink / raw)
To: linux-arm-kernel
Add an empty macro for of_match_node() that will save
some '#ifdef CONFIG_OF' for non-dt builds.
I have chosen to use a macro instead of a function to
be able to avoid defining the first parameter.
In fact, this "struct of_device_id *" first parameter
is usualy not defined as well on non-dt builds.
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
include/linux/of.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/of.h b/include/linux/of.h
index 736b747..92c40a1 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -303,6 +303,7 @@ static inline struct device_node *of_parse_phandle(struct device_node *np,
}
#define of_match_ptr(_ptr) NULL
+#define of_match_node(_matches, _node) NULL
#endif /* CONFIG_OF */
static inline int of_property_read_u32(const struct device_node *np,
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] dt: Add empty of_match_node() macro
2011-10-24 9:53 [PATCH] dt: Add empty of_match_node() macro Nicolas Ferre
@ 2011-10-24 10:06 ` Grant Likely
2011-10-24 14:25 ` Grant Likely
1 sibling, 0 replies; 3+ messages in thread
From: Grant Likely @ 2011-10-24 10:06 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Oct 24, 2011 at 11:53 AM, Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
> Add an empty macro for of_match_node() that will save
> some '#ifdef CONFIG_OF' for non-dt builds.
>
> I have chosen to use a macro instead of a function to
> be able to avoid defining the first parameter.
> In fact, this "struct of_device_id *" first parameter
> is usualy not defined as well on non-dt builds.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> ?include/linux/of.h | ? ?1 +
> ?1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/of.h b/include/linux/of.h
> index 736b747..92c40a1 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -303,6 +303,7 @@ static inline struct device_node *of_parse_phandle(struct device_node *np,
> ?}
>
> ?#define of_match_ptr(_ptr) ? ? NULL
> +#define of_match_node(_matches, _node) NULL
Where possible, I prefer to code to be written in C, not PP. :-)
static inline please.
g.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] dt: Add empty of_match_node() macro
2011-10-24 9:53 [PATCH] dt: Add empty of_match_node() macro Nicolas Ferre
2011-10-24 10:06 ` Grant Likely
@ 2011-10-24 14:25 ` Grant Likely
1 sibling, 0 replies; 3+ messages in thread
From: Grant Likely @ 2011-10-24 14:25 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Oct 24, 2011 at 11:53:32AM +0200, Nicolas Ferre wrote:
> Add an empty macro for of_match_node() that will save
> some '#ifdef CONFIG_OF' for non-dt builds.
>
> I have chosen to use a macro instead of a function to
> be able to avoid defining the first parameter.
> In fact, this "struct of_device_id *" first parameter
> is usualy not defined as well on non-dt builds.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
After private discussion, yes this is okay. I've picked it up.
g.
> ---
> include/linux/of.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/of.h b/include/linux/of.h
> index 736b747..92c40a1 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -303,6 +303,7 @@ static inline struct device_node *of_parse_phandle(struct device_node *np,
> }
>
> #define of_match_ptr(_ptr) NULL
> +#define of_match_node(_matches, _node) NULL
> #endif /* CONFIG_OF */
>
> static inline int of_property_read_u32(const struct device_node *np,
> --
> 1.7.5.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-24 14:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-24 9:53 [PATCH] dt: Add empty of_match_node() macro Nicolas Ferre
2011-10-24 10:06 ` Grant Likely
2011-10-24 14:25 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).