* [PATCH] [TRIVIAL] ARM: pxa: Fix typo 'CONFIG_BACKLIGHT_PWM__MODULE' [not found] <1318347115.5754.3.camel@x61.thuisdomein> @ 2011-10-29 19:28 ` Jiri Kosina 2011-10-29 22:35 ` Marek Vasut 0 siblings, 1 reply; 3+ messages in thread From: Jiri Kosina @ 2011-10-29 19:28 UTC (permalink / raw) To: linux-arm-kernel On Tue, 11 Oct 2011, Paul Bolle wrote: > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > --- > Untested (I don't think I've got the hardware, nor have I got the > toolchain at hand, etc.). > > arch/arm/mach-pxa/colibri-pxa270-income.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-pxa/colibri-pxa270-income.c b/arch/arm/mach-pxa/colibri-pxa270-income.c > index 80538b8..248804b 100644 > --- a/arch/arm/mach-pxa/colibri-pxa270-income.c > +++ b/arch/arm/mach-pxa/colibri-pxa270-income.c > @@ -183,7 +183,7 @@ static inline void income_lcd_init(void) {} > /****************************************************************************** > * Backlight > ******************************************************************************/ > -#if defined(CONFIG_BACKLIGHT_PWM) || defined(CONFIG_BACKLIGHT_PWM__MODULE) > +#if defined(CONFIG_BACKLIGHT_PWM) || defined(CONFIG_BACKLIGHT_PWM_MODULE) > static struct platform_pwm_backlight_data income_backlight_data = { > .pwm_id = 0, > .max_brightness = 0x3ff, I'd like to have this at least compile-tested, adding some CCs. -- Jiri Kosina SUSE Labs ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] [TRIVIAL] ARM: pxa: Fix typo 'CONFIG_BACKLIGHT_PWM__MODULE' 2011-10-29 19:28 ` [PATCH] [TRIVIAL] ARM: pxa: Fix typo 'CONFIG_BACKLIGHT_PWM__MODULE' Jiri Kosina @ 2011-10-29 22:35 ` Marek Vasut 2011-10-30 9:23 ` Nicolas Kaiser 0 siblings, 1 reply; 3+ messages in thread From: Marek Vasut @ 2011-10-29 22:35 UTC (permalink / raw) To: linux-arm-kernel > On Tue, 11 Oct 2011, Paul Bolle wrote: > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > > --- > > Untested (I don't think I've got the hardware, nor have I got the > > toolchain at hand, etc.). > > > > arch/arm/mach-pxa/colibri-pxa270-income.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/arch/arm/mach-pxa/colibri-pxa270-income.c > > b/arch/arm/mach-pxa/colibri-pxa270-income.c index 80538b8..248804b > > 100644 > > --- a/arch/arm/mach-pxa/colibri-pxa270-income.c > > +++ b/arch/arm/mach-pxa/colibri-pxa270-income.c > > @@ -183,7 +183,7 @@ static inline void income_lcd_init(void) {} > > > > /*********************************************************************** > > ******* > > > > * Backlight > > *********************************************************************** > > *******/ > > > > -#if defined(CONFIG_BACKLIGHT_PWM) || > > defined(CONFIG_BACKLIGHT_PWM__MODULE) +#if defined(CONFIG_BACKLIGHT_PWM) > > || defined(CONFIG_BACKLIGHT_PWM_MODULE) > > > > static struct platform_pwm_backlight_data income_backlight_data = { > > > > .pwm_id = 0, > > .max_brightness = 0x3ff, > > I'd like to have this at least compile-tested, adding some CCs. The change is visually ok, add my: Acked-by: Marek Vasut <marek.vasut@gmail.com> ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] [TRIVIAL] ARM: pxa: Fix typo 'CONFIG_BACKLIGHT_PWM__MODULE' 2011-10-29 22:35 ` Marek Vasut @ 2011-10-30 9:23 ` Nicolas Kaiser 0 siblings, 0 replies; 3+ messages in thread From: Nicolas Kaiser @ 2011-10-30 9:23 UTC (permalink / raw) To: linux-arm-kernel * Marek Vasut <marek.vasut@gmail.com>: > > On Tue, 11 Oct 2011, Paul Bolle wrote: > > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > > > --- > > > Untested (I don't think I've got the hardware, nor have I got the > > > toolchain at hand, etc.). > > > > > > arch/arm/mach-pxa/colibri-pxa270-income.c | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/arch/arm/mach-pxa/colibri-pxa270-income.c > > > b/arch/arm/mach-pxa/colibri-pxa270-income.c index 80538b8..248804b > > > 100644 > > > --- a/arch/arm/mach-pxa/colibri-pxa270-income.c > > > +++ b/arch/arm/mach-pxa/colibri-pxa270-income.c > > > @@ -183,7 +183,7 @@ static inline void income_lcd_init(void) {} > > > > > > /*********************************************************************** > > > ******* > > > > > > * Backlight > > > *********************************************************************** > > > *******/ > > > > > > -#if defined(CONFIG_BACKLIGHT_PWM) || > > > defined(CONFIG_BACKLIGHT_PWM__MODULE) +#if defined(CONFIG_BACKLIGHT_PWM) > > > || defined(CONFIG_BACKLIGHT_PWM_MODULE) > > > > > > static struct platform_pwm_backlight_data income_backlight_data = { > > > > > > .pwm_id = 0, > > > .max_brightness = 0x3ff, > > > > I'd like to have this at least compile-tested, adding some CCs. > > The change is visually ok, add my: > > Acked-by: Marek Vasut <marek.vasut@gmail.com> I now remember you already acked this change last year: https://lkml.org/lkml/2010/12/4/41 Sorry that I forgot to resend the patch. Best regards, Nicolas Kaiser ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-30 9:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1318347115.5754.3.camel@x61.thuisdomein>
2011-10-29 19:28 ` [PATCH] [TRIVIAL] ARM: pxa: Fix typo 'CONFIG_BACKLIGHT_PWM__MODULE' Jiri Kosina
2011-10-29 22:35 ` Marek Vasut
2011-10-30 9:23 ` Nicolas Kaiser
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).