From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm/tegra: add support for tegra30 interrupts
Date: Wed, 2 Nov 2011 21:26:26 +0200 [thread overview]
Message-ID: <20111102192625.GD14372@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <20111102192112.GC12913@n2100.arm.linux.org.uk>
hi,
On Wed, Nov 02, 2011 at 07:21:12PM +0000, Russell King - ARM Linux wrote:
> On Wed, Nov 02, 2011 at 12:09:36PM -0700, Stephen Warren wrote:
> > To solve this, I recommend definining ARCH_NR_GPIOs for Tegra, to something
> > large; I see that arch/arm/mach-shmobile defines it to 1024. Failing any
> > disadvantage of using a number that large, I'd go for that...
>
> I'd suggest that we immediately start solving the ARCH_NR_GPIO
> definition a single zImage friendly way - rather than throwing a
> definition into mach/gpio.h, add this into asm/gpio.h:
>
> #if CONFIG_ARCH_NR_GPIO > 0
> #define ARCH_NR_GPIO CONFIG_ARCH_NR_GPIO
> #endif
>
> and in arch/arm/Kconfig:
>
> config ARCH_NR_GPIO
> int
> default 1024 if ARCH_SHMOBILE || ARCH_TEGRA
> ... etc ...
> default 0
>
> The list should be sorted in numeric order, largest first.
>
> This then gives us a path to eliminate the ARCH_NR_GPIO definitions
> from mach/gpio.h - and should allow more mach/gpio.h to become empty.
would it be better to just change the default value in
arm-generic/gpio.h to something very large ?
I mean, ideally that wouldn't be gpio_desc wouldn't be an array anyway
right ?
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20111102/67063f00/attachment.sig>
next prev parent reply other threads:[~2011-11-02 19:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-02 15:38 [PATCH] arm/tegra: add support for tegra30 interrupts Peter De Schrijver
2011-11-02 16:39 ` Stephen Warren
2011-11-02 18:06 ` Stephen Warren
2011-11-02 19:09 ` Stephen Warren
2011-11-02 19:21 ` Russell King - ARM Linux
2011-11-02 19:26 ` Felipe Balbi [this message]
2011-11-02 19:39 ` Russell King - ARM Linux
2011-11-02 19:48 ` Felipe Balbi
2011-11-02 19:54 ` Russell King - ARM Linux
2011-11-02 20:40 ` Felipe Balbi
2011-11-02 18:13 ` Colin Cross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111102192625.GD14372@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).