From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3 v3.1] ARM: S3C64XX: Correct reservation of GPIOs for CPU module on Cragganmore
Date: Thu, 3 Nov 2011 12:10:14 +0000 [thread overview]
Message-ID: <20111103121014.GA11851@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <018d01cc99fc$8a2ee840$9e8cb8c0$%kim@samsung.com>
On Thu, Nov 03, 2011 at 04:45:21PM +0900, Kukjin Kim wrote:
> Mark Brown wrote:
> > #define PCA935X_GPIO_BASE GPIO_BOARD_START
> > #define CODEC_GPIO_BASE (GPIO_BOARD_START + 8)
> > #define GLENFARCLAS_PMIC_GPIO_BASE (GPIO_BOARD_START + 16)
> > +#define BANFF_PMIC_GPIO_BASE
> > (GLENFARCLAS_PMIC_GPIO_BASE + 16)
> Above definitions are at mach/crag6410.h file not mach-crag6410.c file in my
> tree.
> And in my opinion, to use GPIO_BOARD_START is better than to use
> GLENFARCLAS_PMIC_GPIO_BASE like others for easily reading.
I'd prefer it if the were all defined in terms of the preceeding one but
yes.
> So I think, this should be following...?
Yes.
next prev parent reply other threads:[~2011-11-03 12:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 18:42 [PATCH 1/3 v3.1] ARM: S3C64XX: Update for conversion to SAMSUNG_GPIO_EXTRA Mark Brown
2011-10-31 18:42 ` [PATCH 2/3 v3.1] ARM: SAMSUNG: Fix GPIO space reservation for S3C64xx platforms Mark Brown
2011-10-31 18:42 ` [PATCH 3/3 v3.1] ARM: S3C64XX: Correct reservation of GPIOs for CPU module on Cragganmore Mark Brown
2011-11-03 7:45 ` Kukjin Kim
2011-11-03 12:10 ` Mark Brown [this message]
2011-11-04 5:02 ` Kukjin Kim
2011-11-02 12:03 ` [PATCH 1/3 v3.1] ARM: S3C64XX: Update for conversion to SAMSUNG_GPIO_EXTRA Kukjin Kim
2011-11-02 12:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111103121014.GA11851@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).