From mboxrd@z Thu Jan  1 00:00:00 1970
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
Date: Thu, 3 Nov 2011 12:10:14 +0000
Subject: [PATCH 3/3 v3.1] ARM: S3C64XX: Correct reservation of GPIOs for
	CPU module on Cragganmore
In-Reply-To: <018d01cc99fc$8a2ee840$9e8cb8c0$%kim@samsung.com>
References: <1320086573-21184-1-git-send-email-broonie@opensource.wolfsonmicro.com>
	<1320086573-21184-3-git-send-email-broonie@opensource.wolfsonmicro.com>
	<018d01cc99fc$8a2ee840$9e8cb8c0$%kim@samsung.com>
Message-ID: <20111103121014.GA11851@opensource.wolfsonmicro.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Thu, Nov 03, 2011 at 04:45:21PM +0900, Kukjin Kim wrote:
> Mark Brown wrote:

> >  #define PCA935X_GPIO_BASE		GPIO_BOARD_START
> >  #define CODEC_GPIO_BASE		(GPIO_BOARD_START + 8)
> >  #define GLENFARCLAS_PMIC_GPIO_BASE	(GPIO_BOARD_START + 16)
> > +#define BANFF_PMIC_GPIO_BASE
> > 	(GLENFARCLAS_PMIC_GPIO_BASE + 16)

> Above definitions are at mach/crag6410.h file not mach-crag6410.c file in my
> tree.
> And in my opinion, to use GPIO_BOARD_START is better than to use
> GLENFARCLAS_PMIC_GPIO_BASE like others for easily reading.

I'd prefer it if the were all defined in terms of the preceeding one but
yes.

> So I think, this should be following...?

Yes.