linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 6/8] of: add clock providers
Date: Wed, 9 Nov 2011 10:39:45 -0800	[thread overview]
Message-ID: <20111109183945.GL31337@atomide.com> (raw)
In-Reply-To: <1320801583-12774-7-git-send-email-grant.likely@secretlab.ca>

* Grant Likely <grant.likely@secretlab.ca> [111108 16:51]:
> +
> +    /* external oscillator */
> +    osc: oscillator {
> +        compatible = "fixed-clock";
> +        #clock-cells = <1>;
> +        frequency  = <32678>;
> +        clock-output-name = "osc";
> +    };
> +
> +    /* phase-locked-loop device, generates a higher frequency clock
> +     * from the external oscillator reference */
> +    pll: pll {
> +        compatible = "some-pll-interface"
> +        #clock-cells = <1>;
> +        clock-input = <&osc 0>;
> +        clock-input-name = "ref";
> +        reg = <0x4c000 0x1000>;
> +        clock-output-name = "pll", "pll-switched";
> +    };

I think for the clocks we need something describing which bits
in the clock register the "pll" and "pll-switched" belong to.

Otherwise we'll end up having to map all that data in the clock
driver for various SoC variants.

> +    /* UART, using the low frequency oscillator for the baud clock,
> +     * and the high frequency switched PLL output for register
> +     * clocking */
> +    uart {
> +        compatible = "fsl,imx-uart";
> +        reg = <0xa000 0x1000>;
> +        interrupts = <33>;
> +        clock-input = <&osc 0>, <&pll 1>;
> +        clock-input-name = "baud", "register";
> +    };
> +

Here I think we need a better solution for finding the
clocks by name. Doing clock-input = <&osc 0>, <&pll 1> means
that we have redefine the uart for similar SoC many times.

How about using source + option in the name instead:

	   clock-source-name = "osc.osc", "pll.pll-switched";

This same solution would also work for the pinctrl names:

	   pinctrl-source-name = "uart1_rx.uart1_rx", "dss_data7.uart1_tx";

The reason I'm worried here is that just for omap2/3/4 we already
have 3 options for uart1 clock and 19 options for uart1_rx pin!

Using the signal names for both clocks and pinctrl would
allow defining the uart entry for for each reg address instead
of for each clock and pinctrl option.

Regards,

Tony

  parent reply	other threads:[~2011-11-09 18:39 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-09  1:19 [RFC 0/8] Initial DT clock bindings Grant Likely
     [not found] ` <1320801583-12774-8-git-send-email-grant.likely@secretlab.ca>
2011-11-09  2:36   ` [RFC 7/8] arm/clkdev: lookup clocks from OF clock providers Rob Herring
2011-11-16 18:54     ` Grant Likely
     [not found] ` <1320801583-12774-9-git-send-email-grant.likely@secretlab.ca>
2011-11-09  9:31   ` [RFC 8/8] dt/arm: versatile add clock parsing Sascha Hauer
     [not found] ` <1320801583-12774-4-git-send-email-grant.likely@secretlab.ca>
2011-11-14  3:59   ` [RFC 3/8] of: create of_phandle_args to simplify return of phandle parsing data Shawn Guo
2011-11-16 18:47     ` Grant Likely
2011-11-21 15:50   ` Shawn Guo
     [not found] ` <1320801583-12774-7-git-send-email-grant.likely@secretlab.ca>
2011-11-09  2:49   ` [RFC 6/8] of: add clock providers Rob Herring
2011-11-14  2:14     ` Richard Zhao
2011-11-16 19:06       ` Grant Likely
2011-11-09  9:13   ` Sascha Hauer
2011-11-09 11:23     ` Cousson, Benoit
2011-11-09 11:49       ` Sascha Hauer
2011-11-11 19:57         ` Cousson, Benoit
2011-11-16 22:12           ` Grant Likely
2011-11-18  7:48             ` Sascha Hauer
2011-11-09 13:59       ` Rob Herring
2011-11-11 19:50         ` Cousson, Benoit
2011-11-09 13:31     ` Rob Herring
2011-11-09 18:39   ` Tony Lindgren [this message]
2011-11-21 15:37   ` Shawn Guo
2011-11-30 19:38     ` Grant Likely
2011-12-01  6:34       ` Shawn Guo
     [not found] ` <1320801583-12774-2-git-send-email-grant.likely@secretlab.ca>
2011-12-21 10:22   ` [RFC 1/8] gpio/microblaze: Eliminate duplication of of_get_named_gpio_flags() Michal Simek
2012-01-04 18:30     ` Grant Likely
2012-01-05  7:28       ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111109183945.GL31337@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).