* [PATCH v2] ARM: mx28evk: Simplify GPIO requests for mx28evk_fec_reset
@ 2011-11-09 20:36 Fabio Estevam
2011-11-09 21:46 ` Wolfram Sang
0 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2011-11-09 20:36 UTC (permalink / raw)
To: linux-arm-kernel
From: Fabio Estevam <fabio.estevam@freescale.com>
Simplify GPIO requests inside mx28evk_fec_reset by using gpio_request_array.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:
- Make mx28evk_fec_gpios const
arch/arm/mach-mxs/mach-mx28evk.c | 29 ++++++++---------------------
1 files changed, 8 insertions(+), 21 deletions(-)
diff --git a/arch/arm/mach-mxs/mach-mx28evk.c b/arch/arm/mach-mxs/mach-mx28evk.c
index ac2316d..c565c33 100644
--- a/arch/arm/mach-mxs/mach-mx28evk.c
+++ b/arch/arm/mach-mxs/mach-mx28evk.c
@@ -219,6 +219,11 @@ static const struct gpio_led_platform_data mx28evk_led_data __initconst = {
.num_leds = ARRAY_SIZE(mx28evk_leds),
};
+static const struct gpio mx28evk_fec_gpios[] __initconst = {
+ { MX28EVK_FEC_PHY_POWER, GPIOF_OUT_INIT_LOW, "fec-power" },
+ { MX28EVK_FEC_PHY_RESET, GPIOF_OUT_INIT_LOW, "fec-enable" },
+};
+
/* fec */
static void __init mx28evk_fec_reset(void)
{
@@ -231,28 +236,10 @@ static void __init mx28evk_fec_reset(void)
clk_enable(clk);
/* Power up fec phy */
- ret = gpio_request(MX28EVK_FEC_PHY_POWER, "fec-phy-power");
- if (ret) {
- pr_err("Failed to request gpio fec-phy-%s: %d\n", "power", ret);
- return;
- }
-
- ret = gpio_direction_output(MX28EVK_FEC_PHY_POWER, 0);
- if (ret) {
- pr_err("Failed to drive gpio fec-phy-%s: %d\n", "power", ret);
- return;
- }
-
- /* Reset fec phy */
- ret = gpio_request(MX28EVK_FEC_PHY_RESET, "fec-phy-reset");
- if (ret) {
- pr_err("Failed to request gpio fec-phy-%s: %d\n", "reset", ret);
- return;
- }
-
- gpio_direction_output(MX28EVK_FEC_PHY_RESET, 0);
+ ret = gpio_request_array(mx28evk_fec_gpios,
+ ARRAY_SIZE(mx28evk_fec_gpios));
if (ret) {
- pr_err("Failed to drive gpio fec-phy-%s: %d\n", "reset", ret);
+ pr_err("Failed to request FEC gpios: %d\n", ret);
return;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v2] ARM: mx28evk: Simplify GPIO requests for mx28evk_fec_reset
2011-11-09 20:36 [PATCH v2] ARM: mx28evk: Simplify GPIO requests for mx28evk_fec_reset Fabio Estevam
@ 2011-11-09 21:46 ` Wolfram Sang
2011-11-10 6:54 ` Uwe Kleine-König
2011-11-10 7:54 ` Sascha Hauer
0 siblings, 2 replies; 5+ messages in thread
From: Wolfram Sang @ 2011-11-09 21:46 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Nov 09, 2011 at 06:36:38PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Simplify GPIO requests inside mx28evk_fec_reset by using gpio_request_array.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Like it: Acked-by: Wolfram Sang <w.sang@pengutronix.de>
Thanks,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20111109/b4aa0ae2/attachment-0001.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] ARM: mx28evk: Simplify GPIO requests for mx28evk_fec_reset
2011-11-09 21:46 ` Wolfram Sang
@ 2011-11-10 6:54 ` Uwe Kleine-König
2011-11-10 7:54 ` Sascha Hauer
1 sibling, 0 replies; 5+ messages in thread
From: Uwe Kleine-König @ 2011-11-10 6:54 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Nov 09, 2011 at 10:46:03PM +0100, Wolfram Sang wrote:
> On Wed, Nov 09, 2011 at 06:36:38PM -0200, Fabio Estevam wrote:
> > From: Fabio Estevam <fabio.estevam@freescale.com>
> >
> > Simplify GPIO requests inside mx28evk_fec_reset by using gpio_request_array.
> >
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Like it: Acked-by: Wolfram Sang <w.sang@pengutronix.de>
/me to.
Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] ARM: mx28evk: Simplify GPIO requests for mx28evk_fec_reset
2011-11-09 21:46 ` Wolfram Sang
2011-11-10 6:54 ` Uwe Kleine-König
@ 2011-11-10 7:54 ` Sascha Hauer
2011-11-11 20:48 ` Fabio Estevam
1 sibling, 1 reply; 5+ messages in thread
From: Sascha Hauer @ 2011-11-10 7:54 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Nov 09, 2011 at 10:46:03PM +0100, Wolfram Sang wrote:
> On Wed, Nov 09, 2011 at 06:36:38PM -0200, Fabio Estevam wrote:
> > From: Fabio Estevam <fabio.estevam@freescale.com>
> >
> > Simplify GPIO requests inside mx28evk_fec_reset by using gpio_request_array.
> >
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Like it: Acked-by: Wolfram Sang <w.sang@pengutronix.de>
/me not. See my comments to v1.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] ARM: mx28evk: Simplify GPIO requests for mx28evk_fec_reset
2011-11-10 7:54 ` Sascha Hauer
@ 2011-11-11 20:48 ` Fabio Estevam
0 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2011-11-11 20:48 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Nov 10, 2011 at 5:54 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Wed, Nov 09, 2011 at 10:46:03PM +0100, Wolfram Sang wrote:
>> On Wed, Nov 09, 2011 at 06:36:38PM -0200, Fabio Estevam wrote:
>> > From: Fabio Estevam <fabio.estevam@freescale.com>
>> >
>> > Simplify GPIO requests inside mx28evk_fec_reset by using gpio_request_array.
>> >
>> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> Like it: Acked-by: Wolfram Sang <w.sang@pengutronix.de>
>
> /me not. See my comments to v1.
Ok, I will implement your suggestion in v3.
Will wait Shawn?s patch "arm/mxs: fix mmc device adding for
mach-mx28evk" to reach rc2 first.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-11-11 20:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-09 20:36 [PATCH v2] ARM: mx28evk: Simplify GPIO requests for mx28evk_fec_reset Fabio Estevam
2011-11-09 21:46 ` Wolfram Sang
2011-11-10 6:54 ` Uwe Kleine-König
2011-11-10 7:54 ` Sascha Hauer
2011-11-11 20:48 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).