From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: mach-imx: convert logical CPU numbers to physical numbers
Date: Fri, 11 Nov 2011 13:41:35 +0000 [thread overview]
Message-ID: <20111111134135.GH12410@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <20111111130701.GI8732@S2100-06.ap.freescale.net>
On Fri, Nov 11, 2011 at 01:07:02PM +0000, Shawn Guo wrote:
> On Fri, Nov 11, 2011 at 10:56:07AM +0000, Will Deacon wrote:
> > On Fri, Nov 11, 2011 at 10:08:00AM +0000, Will Deacon wrote:
> > > On Fri, Nov 11, 2011 at 09:29:25AM +0000, Sascha Hauer wrote:
> > > > On Tue, Nov 08, 2011 at 02:34:53PM +0000, Will Deacon wrote:
> > > > > This patch uses the new cpu_logical_map() macro for converting logical
> > > > > CPU numbers into physical numbers when releasing CPUs during the SMP
> > > > > boot and CPU hotplug paths.
> > > >
> > > > Shawn, is this one ok?
> > >
> > > I reckon I need to post a v2 because this probably breaks when !SMP.
> >
> > Actually, I take that back. Looks like the function is only used by
> > hotplug.c and platsmp.c, both of which depend on CONFIG_SMP.
> >
> But the build of src.c does not depend on CONFIG_SMP. So when building
> with no CONFIG_SMP, we get:
>
> CC arch/arm/mach-imx/src.o
> arch/arm/mach-imx/src.c: In function ?imx_enable_cpu?:
> arch/arm/mach-imx/src.c:31:2: error: implicit declaration of function ?cpu_logical_map?
> make[2]: *** [arch/arm/mach-imx/src.o] Error 1
> make[1]: *** [arch/arm/mach-imx] Error 2
Ok, then maybe we should #ifdef CONFIG_SMP that function entirely. If that
sounds ok, I can post a v2.
Will
next prev parent reply other threads:[~2011-11-11 13:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 14:34 [PATCH 0/2] cpu_logical_map updates for newly merged platforms Will Deacon
2011-11-08 14:34 ` [PATCH 1/2] ARM: mach-imx: convert logical CPU numbers to physical numbers Will Deacon
2011-11-11 9:29 ` Sascha Hauer
2011-11-11 10:08 ` Will Deacon
2011-11-11 10:56 ` Will Deacon
2011-11-11 13:07 ` Shawn Guo
2011-11-11 13:41 ` Will Deacon [this message]
2011-11-11 23:07 ` Shawn Guo
2011-11-08 14:34 ` [PATCH 2/2] ARM: highbank: " Will Deacon
2011-11-08 15:59 ` Rob Herring
2011-11-08 16:10 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111111134135.GH12410@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).