From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 3/8] ARM: idmap: populate identity map pgd at init time
Date: Sat, 12 Nov 2011 11:14:14 +0000 [thread overview]
Message-ID: <20111112111414.GA27746@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1320767583-21162-4-git-send-email-will.deacon@arm.com>
On Tue, Nov 08, 2011 at 03:52:58PM +0000, Will Deacon wrote:
> When disabling the MMU, it is necessary to take out an identity mapping
> for as much of the address space as possible so that the reset path can
> be executed using its physical address. This is useful for softbooting
> and entering low power states.
>
> This patch allocates a set of pagetables during boot and populates them
> with an identity mapping for all of memory apart from a small window
> containing the kernel image.
I'd like to suggest a slightly different approach, now that we have the
'soft_restart()' thing which is guaranteed to be handling all of the
soft-restart stuff.
First, what does the soft-restart code need to do? It needs to:
1. Perform an orderly shutdown of caches.
2. Perform an orderly shutdown of the MMU.
3. Jump to the supplied physical address with the caches and MMU off,
IRQs disabled, etc.
And for (3) to work across the range of processors with ease, we need
the code to run in a 1:1 mapping so turning off the MMU doesn't leads
to unpredictable results.
We can achieve most of this in the way that we're already doing, so:
1. calling local_irq_disable() and local_fiq_disable() to disable interrupts
2. cpu_proc_fin() to disable caches
3. flush_cache_all() (and outer_flush_all()).
So far, that's very much what the new soft_restart() function already
does. But - can we be smarter about the 1:1 mapping like we are with
the CPU suspend code? Or, to put it another way, can we use the CPU
suspend code's page table which it allocated, and setup a mapping to
cover just the cpu_reset() code itself.
We'd need to reorganize the cpu_reset() code to ensure that the MMU
is actually turned off before we do the final jump, but that shouldn't
be too hard to achieve.
In other words, what I'm saying is that we don't need a 1:1 mapping
setup for the entire userland _if_ we're careful enough with how we
deal with the MMU-off -> jump transition.
This should fix the concerns people have had with kexec and kdump, as
well as fixing up the (broken) v6 and v7 cpu_reset() code.
next prev parent reply other threads:[~2011-11-12 11:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 15:52 [PATCH v5 0/8] kexec fixes and soft restart code Will Deacon
2011-11-08 15:52 ` [PATCH v5 1/8] Revert "ARM: 7098/1: kdump: copy kernel relocation code at the kexec prepare stage" Will Deacon
2011-11-08 15:52 ` [PATCH v5 2/8] ARM: lib: add call_with_stack function for safely changing stack Will Deacon
2011-11-08 15:52 ` [PATCH v5 3/8] ARM: idmap: populate identity map pgd at init time Will Deacon
2011-11-12 11:14 ` Russell King - ARM Linux [this message]
2011-11-13 12:20 ` Will Deacon
2011-11-08 15:52 ` [PATCH v5 4/8] ARM: reset: allow kernelspace mappings to be flat mapped during reset Will Deacon
2011-11-08 15:53 ` [PATCH v5 5/8] ARM: reset: implement soft_restart for jumping to a physical address Will Deacon
2011-11-08 15:53 ` [PATCH v5 6/8] ARM: soft_restart: disable the outer L2 when the last CPU is going down Will Deacon
2011-11-08 15:53 ` [PATCH v5 7/8] ARM: stop: execute platform callback from cpu_stop code Will Deacon
2011-11-08 15:53 ` [PATCH v5 8/8] ARM: kexec: use soft_restart for branching to the reboot buffer Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111112111414.GA27746@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).