public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: richard.zhao@linaro.org (Richard Zhao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] net: fec: convert to clk_prepare/clk_unprepare
Date: Sun, 13 Nov 2011 11:34:33 +0800	[thread overview]
Message-ID: <20111113033427.GC2425@richard-laptop> (raw)
In-Reply-To: <20111112124939.GJ5011@pengutronix.de>

Hi Uwe,
On Sat, Nov 12, 2011 at 01:49:39PM +0100, Uwe Kleine-K?nig wrote:
> Hello Richard,
> 
> On Thu, Nov 10, 2011 at 01:01:44PM +0800, Richard Zhao wrote:
> > Signed-off-by: Richard Zhao <richard.zhao@linaro.org>
> > ---
> >  drivers/net/ethernet/freescale/fec.c |    5 +++++
> >  1 files changed, 5 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/net/ethernet/freescale/fec.c b/drivers/net/ethernet/freescale/fec.c
> > index 1124ce0..92e3585 100644
> > --- a/drivers/net/ethernet/freescale/fec.c
> > +++ b/drivers/net/ethernet/freescale/fec.c
> > @@ -1588,6 +1588,7 @@ fec_probe(struct platform_device *pdev)
> >  		ret = PTR_ERR(fep->clk);
> >  		goto failed_clk;
> >  	}
> > +	clk_prepare(fep->clk);
> What about error checking?
The goal of the patch is migrating to the new generic clock framework.
If the original driver has error check of clk_enable, I also added error check of
clk_prepare. And I've sent out new version patch, which use clk_prepare_enable.

Richard
> 
> Best regards
> Uwe
> 
> -- 
> Pengutronix e.K.                           | Uwe Kleine-K?nig            |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |

      reply	other threads:[~2011-11-13  3:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-10  5:01 [PATCH 1/1] net: fec: convert to clk_prepare/clk_unprepare Richard Zhao
2011-11-12  1:43 ` David Miller
2011-11-13  3:30   ` Richard Zhao
2011-11-12 12:49 ` Uwe Kleine-König
2011-11-13  3:34   ` Richard Zhao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111113033427.GC2425@richard-laptop \
    --to=richard.zhao@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox