linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: pxa: add support for Raumfeld DDX
Date: Wed, 16 Nov 2011 14:11:30 +0000	[thread overview]
Message-ID: <20111116141130.GF29986@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4EC3C376.3040007@gmail.com>

On Wed, Nov 16, 2011 at 03:06:46PM +0100, Daniel Mack wrote:
> On 11/16/2011 02:19 PM, Mark Brown wrote:

> > What I'd expect here is that the arch/arm code would register a
> > different platform device depending on which board it's running on
> > (though actually controlling I2C device registration is enough as ASoC
> > won't probe the sound driver until the components appear).

> Ok, I can do this. However, the two driver will share some logic wrt
> GPIO lines that put the codecs into reset. But ok, we can live with that
> I guess, as it in fact makes the driver smaller and easier to read.

Hrm, I'd expect that that logic would be in the CODEC drivers - they
really do need to know that their registers went away.

> > Look at the snd_soc_dai_link definition, and things like speyside.

> Sorry, I still don't get it. All implementations I can find call
> snd_soc_dai_set_fmt() for the cpu and codec dais from the
> .ops->hw_params function they reference from their snd_soc_dai_links.
> Just like this new code does as well. What am I missing?

Are you *sure* you're looking at current code?  The dai_fmt field isn't
that obscurely named...

  reply	other threads:[~2011-11-16 14:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-07 10:26 [PATCH] ARM: pxa: add support for Raumfeld DDX Daniel Mack
2011-11-15 14:13 ` Mark Brown
2011-11-16 12:56   ` Daniel Mack
2011-11-16 13:19     ` Mark Brown
2011-11-16 14:06       ` Daniel Mack
2011-11-16 14:11         ` Mark Brown [this message]
2011-11-16 14:19           ` Daniel Mack
2011-11-16 15:07     ` [alsa-devel] " Johannes Stezenbach
2011-11-16 16:07       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111116141130.GF29986@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).