From: pdeschrijver@nvidia.com (Peter De Schrijver)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm/tegra: convert tegra20 to GIC devicetree binding
Date: Thu, 17 Nov 2011 17:54:29 +0200 [thread overview]
Message-ID: <20111117155428.GS19069@tbergstrom-lnx.Nvidia.com> (raw)
In-Reply-To: <4EC52BCF.7020609@gmail.com>
On Thu, Nov 17, 2011 at 04:44:15PM +0100, Rob Herring wrote:
> On 11/17/2011 09:07 AM, Peter De Schrijver wrote:
> > Convert tegra20 IRQ intialization to the GIC devicetree binding. Modify the
> > interrupt definitions in the dts files according to
> > Documentation/devicetree/bindings/arm/gic.txt
> >
> > Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
>
> One minor comment below, but otherwise:
>
> Acked-by: Rob Herring <rob.herring@calxeda.com>
>
> > ---
> > arch/arm/boot/dts/tegra-paz00.dts | 2 +-
> > arch/arm/boot/dts/tegra20.dtsi | 52 ++++++++++++++++++------------------
> > arch/arm/mach-tegra/irq.c | 18 +++++++++++-
> > 3 files changed, 43 insertions(+), 29 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/tegra-paz00.dts b/arch/arm/boot/dts/tegra-paz00.dts
> > index 15a949f..7ff8f6f 100644
> > --- a/arch/arm/boot/dts/tegra-paz00.dts
> > +++ b/arch/arm/boot/dts/tegra-paz00.dts
> > @@ -32,7 +32,7 @@
> > #size-cells = <0>;
> > compatible = "nvidia,nvec";
> > reg = <0x7000C500 0x100>;
> > - interrupts = <124>;
> > + interrupts = <0 92 0x04>;
> > clock-frequency = <80000>;
> > request-gpios = <&gpio 170 0>;
> > slave-addr = <138>;
> > diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
> > index 795b921..cd01b01 100644
> > --- a/arch/arm/boot/dts/tegra20.dtsi
> > +++ b/arch/arm/boot/dts/tegra20.dtsi
> > @@ -5,9 +5,9 @@
> > interrupt-parent = <&intc>;
> >
> > intc: interrupt-controller at 50041000 {
> > - compatible = "nvidia,tegra20-gic";
> > + compatible = "arm,cortex-a9-gic";
> > interrupt-controller;
>
> You should add an "interrupt-parent;" here so the gic's parent is null
> and not the gic.
Ok. I will add that in the next version.
Cheers,
Peter.
next prev parent reply other threads:[~2011-11-17 15:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 15:07 [PATCH] arm/tegra: convert tegra20 to GIC devicetree binding Peter De Schrijver
2011-11-17 15:44 ` Rob Herring
2011-11-17 15:54 ` Peter De Schrijver [this message]
[not found] ` <CACxGe6ub2QBO0ZLwNdSvMxP1U087pqL-qL+dfWAbn-08gBQyvg@mail.gmail.com>
2011-11-17 17:15 ` Rob Herring
2011-11-17 20:41 ` Grant Likely
2011-11-17 18:51 ` Stephen Warren
2011-11-18 12:03 ` Peter De Schrijver
2011-11-18 12:03 ` Peter De Schrijver
2011-11-18 16:25 ` Stephen Warren
2011-11-21 12:22 ` Peter De Schrijver
2011-11-21 17:20 ` Stephen Warren
2011-11-23 5:00 ` Peter De Schrijver
2011-11-23 17:25 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111117155428.GS19069@tbergstrom-lnx.Nvidia.com \
--to=pdeschrijver@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox