linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: dave.martin@linaro.org (Dave Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] fix compilation breakage in entry-armv.S
Date: Fri, 18 Nov 2011 15:23:22 +0000	[thread overview]
Message-ID: <20111118152321.GA30405@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.1111161602510.3881@axis700.grange>

On Wed, Nov 16, 2011 at 04:05:04PM +0100, Guennadi Liakhovetski wrote:
> Fix compilation failure, when Thumb support is not enabled:
> 
> arch/arm/kernel/entry-armv.S: Assembler messages:
> arch/arm/kernel/entry-armv.S:501: Error: backward ref to unknown label "2:"
> arch/arm/kernel/entry-armv.S:502: Error: backward ref to unknown label "3:"
> make[2]: *** [arch/arm/kernel/entry-armv.o] Error 1
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>

That looks fine to me.

If Russell is OK with this, please send the patch to his patch system
so we can get this merged.

Reviewed-by: Dave Martin <dave.martin@linaro.org>

> v2: use exactly the same preprocessor condition, as the one used for the 
> code, defining labels "2" and "3"
> 
>  arch/arm/kernel/entry-armv.S |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/kernel/entry-armv.S b/arch/arm/kernel/entry-armv.S
> index 9ad50c4..b145f16 100644
> --- a/arch/arm/kernel/entry-armv.S
> +++ b/arch/arm/kernel/entry-armv.S
> @@ -497,7 +497,7 @@ ENDPROC(__und_usr)
>  	.popsection
>  	.pushsection __ex_table,"a"
>  	.long	1b, 4b
> -#if __LINUX_ARM_ARCH__ >= 7
> +#if CONFIG_ARM_THUMB && __LINUX_ARM_ARCH__ >= 6 && CONFIG_CPU_V7
>  	.long	2b, 4b
>  	.long	3b, 4b
>  #endif
> -- 
> 1.7.2.5
> 

  reply	other threads:[~2011-11-18 15:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-08 11:36 [PATCH] fix compilation breakage in entry-armv.S Guennadi Liakhovetski
2011-11-08 11:40 ` Russell King - ARM Linux
2011-11-08 12:03   ` Guennadi Liakhovetski
2011-11-08 12:08     ` Russell King - ARM Linux
2011-11-11 15:15     ` Dave Martin
2011-11-16 15:05       ` [PATCH v2] " Guennadi Liakhovetski
2011-11-18 15:23         ` Dave Martin [this message]
2011-11-19 19:03           ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111118152321.GA30405@localhost.localdomain \
    --to=dave.martin@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).