From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: omap2: select ARM_AMBA if OMAP3_EMU is defined
Date: Fri, 18 Nov 2011 16:25:42 -0800 [thread overview]
Message-ID: <20111119002542.GY31337@atomide.com> (raw)
In-Reply-To: <1320726974-11912-1-git-send-email-tom.leiming@gmail.com>
* tom.leiming at gmail.com <tom.leiming@gmail.com> [111107 20:02]:
> From: Ming Lei <tom.leiming@gmail.com>
>
> This patch selects ARM_AMBA if OMAP3_EMU is defined because
> OC_ETM depends on ARM_AMBA, so fix the link failure[1].
Thanks applying into fixes.
Tony
>
> [1],
> arch/arm/kernel/built-in.o: In function `etm_remove':
> /home/tom/git/omap/linux-2.6-omap/arch/arm/kernel/etm.c:609: undefined
> reference to `amba_release_regions'
> arch/arm/kernel/built-in.o: In function `etb_remove':
> /home/tom/git/omap/linux-2.6-omap/arch/arm/kernel/etm.c:409: undefined
> reference to `amba_release_regions'
> arch/arm/kernel/built-in.o: In function `etm_init':
> /home/tom/git/omap/linux-2.6-omap/arch/arm/kernel/etm.c:640: undefined
> reference to `amba_driver_register'
> /home/tom/git/omap/linux-2.6-omap/arch/arm/kernel/etm.c:646: undefined
> reference to `amba_driver_register'
> /home/tom/git/omap/linux-2.6-omap/arch/arm/kernel/etm.c:648: undefined
> reference to `amba_driver_unregister'
> arch/arm/kernel/built-in.o: In function `etm_probe':
> /home/tom/git/omap/linux-2.6-omap/arch/arm/kernel/etm.c:545: undefined
> reference to `amba_request_regions'
> /home/tom/git/omap/linux-2.6-omap/arch/arm/kernel/etm.c:595: undefined
> reference to `amba_release_regions'
> arch/arm/kernel/built-in.o: In function `etb_probe':
> /home/tom/git/omap/linux-2.6-omap/arch/arm/kernel/etm.c:347: undefined
> reference to `amba_request_regions'
> /home/tom/git/omap/linux-2.6-omap/arch/arm/kernel/etm.c:392: undefined
> reference to `amba_release_regions'
> arch/arm/mach-omap2/built-in.o: In function `emu_init':
> /home/tom/git/omap/linux-2.6-omap/arch/arm/mach-omap2/emu.c:62:
> undefined reference to `amba_device_register'
> /home/tom/git/omap/linux-2.6-omap/arch/arm/mach-omap2/emu.c:63:
> undefined reference to `amba_device_register'
> make: *** [.tmp_vmlinux1] Error 1
> making modules
>
> Signed-off-by: Ming Lei <tom.leiming@gmail.com>
> ---
> arch/arm/mach-omap2/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index 5034147..e1293aa 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -334,6 +334,7 @@ config MACH_OMAP4_PANDA
> config OMAP3_EMU
> bool "OMAP3 debugging peripherals"
> depends on ARCH_OMAP3
> + select ARM_AMBA
> select OC_ETM
> help
> Say Y here to enable debugging hardware of omap3
> --
> 1.7.5.4
>
prev parent reply other threads:[~2011-11-19 0:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 4:36 [PATCH] arm: omap2: select ARM_AMBA if OMAP3_EMU is defined tom.leiming at gmail.com
2011-11-19 0:25 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111119002542.GY31337@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).