From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1] dts: tegra-ventana: use proper root instead of /dev/ram
Date: Sun, 20 Nov 2011 16:49:30 -0800 [thread overview]
Message-ID: <20111121004930.GA17338@quad.lixom.net> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF1740805E1B@HQMAIL01.nvidia.com>
On Tue, Nov 15, 2011 at 11:16:51AM -0800, Stephen Warren wrote:
> Varun Wadekar wrote at Monday, November 14, 2011 11:21 PM:
> > From: Pritesh Raithatha <praithatha@nvidia.com>
> >
> > The root file system on ventana resides on /dev/mmcblk0p1.
>
> Well, that's entirely up to however the user set up their system, although
> I admit mmcblk0p1 is likely to be the common case; I certainly carry
> basically this patch locally for many boards.
>
> > Update the dts file to use the proper root instead of /dev/ram.
> >
> > Signed-off-by: Pritesh Raithatha <praithatha@nvidia.com>
> > Signed-off-by: Varun Wadekar <vwadekar@nvidia.com>
>
> Acked-by: Stephen Warren <swarren@nvidia.com>
>
> Of course, perhaps an even better solution is to just remove /chosen from
> all the board .dts files, and stop using CONFIG_APPENDED_DTB since U-boot
> supports FDT, and will update the cmdline with whatever the user chose.
> Still, I think this is probably OK for now.
Actually, removing the default root path is probably a better idea, since it
will vary from installation to installation and doesn't make sense to hard
code.
There's two ways to solve this with u-boot:
* Boot with an u-boot that knows how to pass a device tree (and add the
bootargs to it before launching the kernel, and do so by either booting
a fitImage or by loading the device tree explicitly.
* Use the appended-dtb kernel format, and select the ARM_ATAG_DTB_COMPAT
option. That will mean that the bootargs passed in from atags are moved over
to the device tree.
So, I would rather see a patch removing the root= argument alltogether.
Thanks!
-Olof
next prev parent reply other threads:[~2011-11-21 0:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 6:21 [PATCH v1] dts: tegra-ventana: use proper root instead of /dev/ram Varun Wadekar
2011-11-15 19:16 ` Stephen Warren
2011-11-21 0:49 ` Olof Johansson [this message]
2011-11-21 16:56 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111121004930.GA17338@quad.lixom.net \
--to=olof@lixom.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).