From: dave.martin@linaro.org (Dave Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: amba: Auto-generate AMBA driver module aliases during modpost
Date: Mon, 21 Nov 2011 14:18:17 +0000 [thread overview]
Message-ID: <20111121141817.GB14679@localhost.localdomain> (raw)
In-Reply-To: <20111121131022.GE30612@pengutronix.de>
On Mon, Nov 21, 2011 at 02:10:22PM +0100, Uwe Kleine-K?nig wrote:
> Hello Dave,
>
> On Mon, Nov 21, 2011 at 10:48:30AM +0000, Dave Martin wrote:
> > --- a/drivers/amba/bus.c
> > +++ b/drivers/amba/bus.c
> > @@ -52,7 +52,14 @@ static int amba_uevent(struct device *dev, struct kobj_uevent_env *env)
> > int retval = 0;
> >
> > retval = add_uevent_var(env, "AMBA_ID=%08x", pcdev->periphid);
> > - return retval;
> > + if (retval)
> > + return retval;
> > +
> > + retval = add_uevent_var(env, "MODALIAS=amba:d%08X", pcdev->periphid);
> > + if (retval)
> > + return retval;
> > +
> > + return 0;
> Just return retval here?
Hmmm, yes -- I'm not sure why I did things that way.
I'll get rid of the final if () and do as you suggest.
Cheers
---Dave
next prev parent reply other threads:[~2011-11-21 14:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 10:48 [PATCH 0/2 REPOST] ARM: amba: Enable module alias autogeneration for AMBA drivers Dave Martin
2011-11-21 10:48 ` [PATCH 1/2] ARM: amba: Move definition of struct amba_id to mod_devicetable.h Dave Martin
2011-11-21 10:48 ` [PATCH 2/2] ARM: amba: Auto-generate AMBA driver module aliases during modpost Dave Martin
2011-11-21 13:10 ` Uwe Kleine-König
2011-11-21 14:18 ` Dave Martin [this message]
2011-11-21 12:31 ` [PATCH 0/2 REPOST] ARM: amba: Enable module alias autogeneration for AMBA drivers Russell King - ARM Linux
2011-11-21 14:16 ` Dave Martin
-- strict thread matches above, loose matches on Subject: below --
2011-10-14 10:04 [PATCH 0/2] " Dave Martin
2011-10-14 10:04 ` [PATCH 2/2] ARM: amba: Auto-generate AMBA driver module aliases during modpost Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111121141817.GB14679@localhost.localdomain \
--to=dave.martin@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox