From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm/imx: use Kconfig choice for low-level debug UART selection
Date: Tue, 22 Nov 2011 14:30:40 +0100 [thread overview]
Message-ID: <20111122133040.GG19986@pengutronix.de> (raw)
In-Reply-To: <20111122132055.GA32572@mudshark.cambridge.arm.com>
On Tue, Nov 22, 2011 at 01:20:55PM +0000, Will Deacon wrote:
> On Tue, Nov 22, 2011 at 01:02:33PM +0000, Uwe Kleine-K?nig wrote:
> > On Tue, Nov 22, 2011 at 11:50:17AM +0000, Will Deacon wrote:
> > > In the end I'd like to remove DEBUG_LL_UART_NONE. It's only there to service
> > > the platforms which have not yet added an entry to the choice.
> > Why not remove it already now? If I remove it together with the entry
> > for my machine and modify mach/debug-macro.S to do the right thing
> > for my machine even without DEBUG_IMX25_UART, my build just works.
>
> I'm fairly sure this will break the build for everybody who doesn't have an
> entry in Kconfig.debug choice if they try and select DEBUG_LL.
Ah, I see the problem. It's more subtile than just failure to build: it
autoselects DEBUG_ICEDCC then.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2011-11-22 13:30 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-16 21:41 [PATCH 1/3] ARM: debug: use kconfig choice for selecting DEBUG_LL UART Will Deacon
2011-08-16 21:41 ` [PATCH 2/3] ARM: plat-samsung: use Kconfig choice for debug UART selection Will Deacon
2011-10-10 11:56 ` Thomas Abraham
2011-10-10 12:23 ` Will Deacon
2011-10-10 12:35 ` Thomas Abraham
2011-10-10 13:34 ` Will Deacon
2011-10-10 13:38 ` Thomas Abraham
2011-08-16 21:41 ` [PATCH 3/3] ARM: realview: " Will Deacon
2011-08-18 4:06 ` [PATCH 1/3] ARM: debug: use kconfig choice for selecting DEBUG_LL UART Nicolas Pitre
2011-08-18 9:33 ` Will Deacon
2011-08-18 16:11 ` Shawn Guo
2011-08-18 16:07 ` Will Deacon
2011-08-19 4:59 ` Shawn Guo
2011-08-19 11:08 ` Will Deacon
2011-08-19 11:37 ` Shawn Guo
2011-08-19 12:32 ` Will Deacon
2011-08-19 15:49 ` Nicolas Pitre
2011-08-21 9:14 ` Russell King - ARM Linux
2011-08-21 17:35 ` Nicolas Pitre
2011-08-21 18:26 ` Russell King - ARM Linux
2011-08-21 19:02 ` Nicolas Pitre
2011-08-21 19:18 ` Russell King - ARM Linux
2011-08-21 19:22 ` Russell King - ARM Linux
2011-08-21 20:07 ` Nicolas Pitre
2011-08-21 20:54 ` Russell King - ARM Linux
2011-08-21 21:00 ` Nicolas Pitre
2011-08-21 21:29 ` Russell King - ARM Linux
2011-08-21 22:00 ` Nicolas Pitre
2011-08-21 19:53 ` Nicolas Pitre
2011-09-06 9:28 ` Tony Lindgren
2011-09-06 9:37 ` Russell King - ARM Linux
2011-09-06 10:27 ` Tony Lindgren
2011-09-06 10:52 ` Russell King - ARM Linux
2011-09-06 11:01 ` Tony Lindgren
2011-09-06 11:07 ` Russell King - ARM Linux
2011-09-06 19:45 ` Uwe Kleine-König
2011-08-19 14:54 ` Nicolas Pitre
2011-08-19 4:56 ` [PATCH] arm/imx: use Kconfig choice for low-level debug UART selection Shawn Guo
2011-08-19 6:35 ` Sascha Hauer
2011-08-19 7:00 ` Shawn Guo
2011-08-19 11:09 ` Will Deacon
2011-08-19 11:39 ` Sascha Hauer
2011-08-19 12:35 ` Will Deacon
2011-08-19 17:15 ` Sascha Hauer
2011-08-21 9:18 ` Russell King - ARM Linux
2011-08-21 11:25 ` Will Deacon
2011-08-21 17:59 ` Nicolas Pitre
2011-08-21 18:17 ` Russell King - ARM Linux
2011-08-21 18:28 ` Nicolas Pitre
2011-08-21 18:33 ` Russell King - ARM Linux
2011-11-22 8:58 ` Uwe Kleine-König
2011-11-22 11:50 ` Will Deacon
2011-11-22 13:02 ` Uwe Kleine-König
2011-11-22 13:20 ` Will Deacon
2011-11-22 13:30 ` Uwe Kleine-König [this message]
2011-11-22 15:48 ` Russell King - ARM Linux
2011-11-22 16:38 ` Uwe Kleine-König
2011-11-22 16:47 ` Mark Brown
2011-11-22 17:13 ` Uwe Kleine-König
2011-11-22 20:24 ` Russell King - ARM Linux
2011-11-22 21:19 ` Arnd Bergmann
2011-11-22 23:00 ` Mark Brown
2011-11-23 10:57 ` Will Deacon
2011-09-15 17:34 ` [PATCH 1/3] ARM: debug: use kconfig choice for selecting DEBUG_LL UART Stephen Boyd
2011-09-16 11:41 ` Will Deacon
2011-09-19 18:01 ` [PATCH 1/2] ARM: debug: Add CLSP711X_UART1 config choice Stephen Boyd
2011-09-19 18:01 ` [PATCH 2/2] ARM: debug: Move DEBUG_ICEDCC into the DEBUG_LL choice Stephen Boyd
2011-09-19 21:25 ` [PATCH 1/2] ARM: debug: Add CLSP711X_UART1 config choice Will Deacon
2011-09-19 22:12 ` Stephen Boyd
2011-09-19 22:41 ` Russell King - ARM Linux
2011-09-19 22:55 ` Stephen Boyd
2011-11-22 20:42 ` Russell King - ARM Linux
2011-09-19 23:14 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111122133040.GG19986@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).