linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] arm/dt: tegra: Fix SDHCI nodes to match board files
Date: Tue, 22 Nov 2011 17:23:38 +0100	[thread overview]
Message-ID: <20111122162338.GN21480@game.jcrosoft.org> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF174F08C3AF@HQMAIL01.nvidia.com>

On 08:12 Tue 22 Nov     , Stephen Warren wrote:
> Jean-Christophe PLAGNIOL-VILLARD wrote at Tuesday, November 22, 2011 1:38 AM:
> > On 14:44 Mon 21 Nov     , Stephen Warren wrote:
> > > Mark any SDHCI controllers that aren't registered by the board files as
> > > disabled in the device-tree files.
> > >
> > > In practice, these controllers:
> > >
> > > * Have nothing hooked up to them at all, or
> > > * For ports intended for SDIO usage, the drivers for anything that might
> > >   be attached are not in the device-tree yet. If/when drivers appear, the
> > >   SD/MMC port can be re-enabled.
> > >
> > > The only possible exception is TrimSlice's mico SD slot, but that wasn't
> > > enabled in the board files before anyway, and doesn't work when all the
> > > SDHCI controllers are enabled anyway.
> > it will be better to invert the logic
> > 
> > just enable what you are supposed too
> 
> It used to be that way when the files were first added, but they got
> switched around this way to match standard practice.
this is a bad practice because you can enable stuff that a hardware is not
supposed to use

and this silenty without anyone notice until you test the hardware

and you add more line and changeset

Best Regrds,
J.

  reply	other threads:[~2011-11-22 16:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-21 21:44 [PATCH 1/5] arm/dt: tegra: Remove /memreserve/ from device-tree files Stephen Warren
2011-11-21 21:44 ` [PATCH 2/5] arm/dt: tegra: Remove /chosen node Stephen Warren
2011-12-08  0:20   ` Olof Johansson
2011-11-21 21:44 ` [PATCH 3/5] arm/dt: tegra: Fix I2C nodes to match board files Stephen Warren
2011-12-08  0:20   ` Olof Johansson
2011-11-21 21:44 ` [PATCH 4/5] arm/dt: tegra: Fix serial " Stephen Warren
2011-12-08  0:21   ` Olof Johansson
2011-11-21 21:44 ` [PATCH 5/5] arm/dt: tegra: Fix SDHCI " Stephen Warren
2011-11-22  8:38   ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-22 16:12     ` Stephen Warren
2011-11-22 16:23       ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2011-12-08  0:21   ` Olof Johansson
2011-11-22 10:41 ` [PATCH 1/5] arm/dt: tegra: Remove /memreserve/ from device-tree files Marc Dietrich
2011-11-22 16:25   ` Stephen Warren
2011-11-22 21:36     ` [PATCH 1/5] arm/dt: tegra: Remove /memreserve/ from device-treefiles Marc Dietrich
2011-12-08  0:22     ` [PATCH 1/5] arm/dt: tegra: Remove /memreserve/ from device-tree files Olof Johansson
2011-12-08  0:19 ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111122162338.GN21480@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).