From: pdeschrijver@nvidia.com (Peter De Schrijver)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm/tegra: convert tegra20 to GIC devicetree binding
Date: Wed, 23 Nov 2011 07:00:12 +0200 [thread overview]
Message-ID: <20111123050012.GS19069@tbergstrom-lnx.Nvidia.com> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF174F08C0E5@HQMAIL01.nvidia.com>
> > > But the WM8903 still has the same interrupt-parent as everything else,
> > > since it's inherited from /interrupt-parent and doesn't define its own.
> > > Perhaps this is a mistake?
> >
> > Yes. I think this is a mistake. If we want the device tree to reflect the
> > hardware, I think the WM8903 node should specify the GPIO, not the IRQ
> > number.
>
> Hmm. This somewhat goes back to the previous irq_to_gpio discussion...
>
> The WM8903 driver only cares about having an interrupt. In this case at
> least, the driver never performs any GPIO-like manipulation on this
> interrupt line. As such, shouldn't the driver receive the interrupt ID
> to use?
>
Maybe it should then. I guess also edge vs level and polarity need to be
specified?
> The rationale here is that while the WM8903's interrupt output is hooked
> to a GPIO input on Tegra systems, there's no reason to believe that it
> couldn't be hooked to a dedicated interrupt input pin on some other SoC
> (i.e. not a GPIO). In that case, there'd be no GPIO to pass to the driver.
>
> Now perhaps what this means is that we need a DT binding for "the IRQ
> generated by this given GPIO pin", rather than encoding that interrupt
> number into the WM8903 node directly? That's certainly exactly what we
> do when creating the platform data in board files in this case.
I think we need to model the GPIO IRQs as a seperate interrupt controller.
That way the WM8903 node can refer to the GPIO IRQ as an IRQ without
hardcoding the global interrupt number, similar to the way we specify the
SPI number in the device nodes and not the global interrupt number.
Cheers,
Peter.
next prev parent reply other threads:[~2011-11-23 5:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 15:07 [PATCH] arm/tegra: convert tegra20 to GIC devicetree binding Peter De Schrijver
2011-11-17 15:44 ` Rob Herring
2011-11-17 15:54 ` Peter De Schrijver
[not found] ` <CACxGe6ub2QBO0ZLwNdSvMxP1U087pqL-qL+dfWAbn-08gBQyvg@mail.gmail.com>
2011-11-17 17:15 ` Rob Herring
2011-11-17 20:41 ` Grant Likely
2011-11-17 18:51 ` Stephen Warren
2011-11-18 12:03 ` Peter De Schrijver
2011-11-18 12:03 ` Peter De Schrijver
2011-11-18 16:25 ` Stephen Warren
2011-11-21 12:22 ` Peter De Schrijver
2011-11-21 17:20 ` Stephen Warren
2011-11-23 5:00 ` Peter De Schrijver [this message]
2011-11-23 17:25 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111123050012.GS19069@tbergstrom-lnx.Nvidia.com \
--to=pdeschrijver@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox