linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 5/5] clk: export tree topology and clk data via sysfs
Date: Wed, 23 Nov 2011 08:59:04 -0800	[thread overview]
Message-ID: <20111123165903.GF31337@atomide.com> (raw)
In-Reply-To: <20111122191347.GB4844@kroah.com>

Hi Mike,

* Greg KH <greg@kroah.com> [111122 10:51]:
> On Tue, Nov 22, 2011 at 09:57:41AM -0800, Mike Turquette wrote:
> > > Ah, comments like this warm my heart.
> > >
> > > Come on, no abusing the kobject code please, if have problems with how
> > > the kernel core works, and it doesn't do things you want it to, then why
> > > not change it to work properly for you, or at the least, ASK ME!!!
> > 
> > Ok, I'm asking you now.  There are two ways to solve this problem:
> > 
> > 1) have kobject core create the lists linking the objects but defer
> > allocations and any interactions with sysfs until later in the boot
> > sequence, OR

Please just make it all a loadable module using regular devices. That
makes the development a lot easier and as a side effect also guarantees
we're using standard interfaces.

Sure most platforms using it want it compiled in at least for now,
but in the long run it should be possible to load it when we get to
initramfs. For the early usage of clocks..

> > 2) my code can create a list of clks (the same way that clkdev does)
> > and defer kobject/sysfs stuff until later, which walks the list made
> > during early-boot

..let's plan on getting rid of the early usage of clocks instead so
you don't have the issue of deferring stuff.

> > #1 is most closely aligned with the code I have here, #2 presents
> > challenges that I haven't really though through.  I know that OMAP
> > uses the clk framework VERY early in it's boot sequence, but as long
> > as the per-clk data is properly initialized then it should be OK.
> > 
> > What do you think?

We initialize clocksource/clockevent clocks early, but we can do that
without clock fwk initially, then let a clockevent driver take over
later on. That should solve your issues #1 and #2.

> #3 - use debugfs and don't try to create a sysfs interface for the clock
> structures :)

Sounds like the debugfs is the way to go :)

Tony

  parent reply	other threads:[~2011-11-23 16:59 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-22  1:40 [PATCH v3 0/5] common clk framework Mike Turquette
2011-11-22  1:40 ` [PATCH v3 1/5] clk: Kconfig: add entry for HAVE_CLK_PREPARE Mike Turquette
2011-11-26  0:51   ` Shawn Guo
2011-11-22  1:40 ` [PATCH v3 2/5] Documentation: common clk API Mike Turquette
2011-11-23  2:03   ` Saravana Kannan
2011-11-23 20:33     ` Turquette, Mike
2011-11-26  8:47       ` Shawn Guo
2011-11-27  1:43         ` Turquette, Mike
2011-11-22  1:40 ` [PATCH v3 3/5] clk: introduce the common clock framework Mike Turquette
2011-11-23  3:12   ` Saravana Kannan
2011-11-23 21:30     ` Turquette, Mike
2011-11-26 13:22   ` Shawn Guo
2011-11-27  6:00     ` Turquette, Mike
2011-12-01  1:20   ` Paul Walmsley
2011-12-01  5:53     ` Turquette, Mike
2011-12-01  6:39       ` Paul Walmsley
2011-12-01 14:42         ` Mark Brown
2011-12-01 18:25           ` Turquette, Mike
2011-12-01 18:30           ` Paul Walmsley
2011-12-01 18:32             ` Mark Brown
2011-12-01 22:03             ` Russell King - ARM Linux
2011-12-03  1:04               ` Paul Walmsley
2011-12-01  8:45     ` Russell King - ARM Linux
2011-12-02 17:13       ` Paul Walmsley
2011-12-02 20:23         ` Russell King - ARM Linux
2011-12-02 20:32           ` Uwe Kleine-König
2011-12-01  2:13   ` Paul Walmsley
2011-12-05 21:15   ` Paul Walmsley
2011-12-05 23:48     ` Russell King - ARM Linux
2011-12-06  1:37       ` Paul Walmsley
2011-12-06  6:28         ` Paul Walmsley
2011-12-05 23:40   ` Turquette, Mike
2011-11-22  1:40 ` [PATCH v3 4/5] clk: basic gateable and fixed-rate clks Mike Turquette
2011-11-22 13:11   ` Arnd Bergmann
2011-11-22 15:03     ` Mark Salter
2011-11-22 15:49       ` Arnd Bergmann
2011-11-26 13:48   ` Shawn Guo
2011-11-27  6:03     ` Turquette, Mike
2011-11-27  0:09   ` Shawn Guo
2011-11-22  1:40 ` [PATCH v3 5/5] clk: export tree topology and clk data via sysfs Mike Turquette
2011-11-22 13:07   ` Arnd Bergmann
2011-11-22 17:42     ` Mike Turquette
2011-11-22 15:49   ` Greg KH
2011-11-22 17:57     ` Mike Turquette
2011-11-22 19:13       ` Greg KH
2011-11-23  3:48         ` Saravana Kannan
2011-11-23 20:43           ` Turquette, Mike
2011-11-23 16:59         ` Tony Lindgren [this message]
2011-11-23 18:06           ` Russell King - ARM Linux
2011-11-23 18:55             ` Tony Lindgren
2011-11-23 19:09               ` Mark Brown
2011-11-23 19:19                 ` Tony Lindgren
2011-11-23 22:42               ` Russell King - ARM Linux
2011-11-24  1:08                 ` Tony Lindgren
     [not found]   ` <CACxGe6sOd6MiyYaok6BsihJtp-NNsm3WQf+aUPGMRFRpSLw2mQ@mail.gmail.com>
2011-11-22 18:01     ` Mike Turquette
2011-11-22 19:19       ` Grant Likely
2011-11-22 20:02         ` Arnd Bergmann
2011-11-22 20:19           ` Turquette, Mike
2011-11-22 15:42 ` [PATCH v3 0/5] common clk framework Greg KH
2011-11-22 17:45   ` Russell King - ARM Linux
2011-11-22 18:09     ` Mike Turquette
2011-11-22 19:12       ` Greg KH
2011-11-22 19:30         ` Mark Brown
2011-11-26  7:06 ` Shawn Guo
2011-11-27  1:12   ` Turquette, Mike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111123165903.GF31337@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).